From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 153D7C43218 for ; Tue, 11 Jun 2019 08:27:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1E7720673 for ; Tue, 11 Jun 2019 08:27:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1E7720673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52792 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hac7g-00009X-Ve for qemu-devel@archiver.kernel.org; Tue, 11 Jun 2019 04:27:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50356) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hac6I-0006yH-Mm for qemu-devel@nongnu.org; Tue, 11 Jun 2019 04:25:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hac6H-0004cD-Lx for qemu-devel@nongnu.org; Tue, 11 Jun 2019 04:25:50 -0400 Received: from mga18.intel.com ([134.134.136.126]:57752) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hac6H-0004Zj-Cj for qemu-devel@nongnu.org; Tue, 11 Jun 2019 04:25:49 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 01:25:46 -0700 X-ExtLoop1: 1 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga004.fm.intel.com with ESMTP; 11 Jun 2019 01:25:45 -0700 Date: Tue, 11 Jun 2019 16:25:20 +0800 From: Wei Yang To: Wei Yang Message-ID: <20190611082520.GA11125@richard> References: <20190402003106.17614-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190402003106.17614-1-richardw.yang@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.126 Subject: Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote: >MigrationState->bytes_xfer is only set to 0 in migrate_init(). > >Remove this unnecessary field. > >Signed-off-by: Wei Yang Hi, David Are you willing to pick up this one? >--- > migration/migration.c | 1 - > migration/migration.h | 1 - > 2 files changed, 2 deletions(-) > >diff --git a/migration/migration.c b/migration/migration.c >index dea7078bf4..c929cf8d0f 100644 >--- a/migration/migration.c >+++ b/migration/migration.c >@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s) > * parameters/capabilities that the user set, and > * locks. > */ >- s->bytes_xfer = 0; > s->cleanup_bh = 0; > s->to_dst_file = NULL; > s->rp_state.from_dst_file = NULL; >diff --git a/migration/migration.h b/migration/migration.h >index 852eb3c4e9..b9efbe9168 100644 >--- a/migration/migration.h >+++ b/migration/migration.h >@@ -116,7 +116,6 @@ struct MigrationState > DeviceState parent_obj; > > /*< public >*/ >- size_t bytes_xfer; > QemuThread thread; > QEMUBH *cleanup_bh; > QEMUFile *to_dst_file; >-- >2.19.1 -- Wei Yang Help you, Help me