From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Cleber Rosa <crosa@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Aleksandar Rikalo" <arikalo@wavecomp.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 2/6] BootLinuxConsoleTest: Do not log empty lines
Date: Tue, 11 Jun 2019 14:14:52 -0300 [thread overview]
Message-ID: <20190611171456.23444-3-ehabkost@redhat.com> (raw)
In-Reply-To: <20190611171456.23444-1-ehabkost@redhat.com>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Avoid to log empty lines in console debug logs.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20190520220635.10961-2-f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
Acked-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
tests/acceptance/boot_linux_console.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index 6aa084e049..e86e66900a 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -37,8 +37,10 @@ class BootLinuxConsole(Test):
console = self.vm.console_socket.makefile()
console_logger = logging.getLogger('console')
while True:
- msg = console.readline()
- console_logger.debug(msg.strip())
+ msg = console.readline().strip()
+ if not msg:
+ continue
+ console_logger.debug(msg)
if success_message in msg:
break
if failure_message in msg:
--
2.18.0.rc1.1.g3f1ff2140
next prev parent reply other threads:[~2019-06-11 17:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 17:14 [Qemu-devel] [PULL 0/6] Python queue, 2019-06-11 Eduardo Habkost
2019-06-11 17:14 ` [Qemu-devel] [PULL 1/6] tests/boot_linux_console: Let extract_from_deb handle various compressions Eduardo Habkost
2019-06-11 17:14 ` Eduardo Habkost [this message]
2019-06-11 17:14 ` [Qemu-devel] [PULL 3/6] BootLinuxConsoleTest: Test the SmartFusion2 board Eduardo Habkost
2019-06-11 17:14 ` [Qemu-devel] [PULL 4/6] BootLinuxConsoleTest: Test nanoMIPS kernels on the I7200 CPU Eduardo Habkost
2019-06-11 17:14 ` [Qemu-devel] [PULL 5/6] BootLinuxConsoleTest: Run kerneltests BusyBox on Malta Eduardo Habkost
2019-06-11 17:14 ` [Qemu-devel] [PULL 6/6] travis: Make check-acceptance job more verbose Eduardo Habkost
2019-06-12 20:49 ` Philippe Mathieu-Daudé
2019-06-12 20:52 ` Eduardo Habkost
2019-06-12 22:33 ` Philippe Mathieu-Daudé
2019-06-12 22:47 ` Cleber Rosa
2019-06-12 23:12 ` Philippe Mathieu-Daudé
2019-06-12 12:49 ` [Qemu-devel] [PULL 0/6] Python queue, 2019-06-11 Peter Maydell
2019-06-18 13:27 ` Peter Maydell
2019-06-18 14:01 ` Cleber Rosa
2019-06-18 15:38 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611171456.23444-3-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).