From: Wei Yang <richard.weiyang@gmail.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Wei Yang <richardw.yang@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] migration/xbzrle: make xbzrle_encode_buffer little easier to read
Date: Wed, 12 Jun 2019 15:02:27 +0000 [thread overview]
Message-ID: <20190612150227.ycohdktaf4yconpl@master> (raw)
In-Reply-To: <87o933m708.fsf@trasno.org>
On Wed, Jun 12, 2019 at 12:29:27PM +0200, Juan Quintela wrote:
>"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
>> * Wei Yang (richardw.yang@linux.intel.com) wrote:
>>> The encoding process could be described below:
>>>
>>> for [content]
>>> get length of a run
>>> encode this run
>>>
>>> By refactoring the code with this logic, it maybe a little easier to
>>> understand.
>>>
>>
>> Are lines like this really making it easier to read?
>>
>> Juan: Opinion?
>
>Code is easier to understand .....
>
>For values that I understand the code. I need to take a big breath and
>will take a deep look at it and see if it really does the same.
>
Haha, thanks for your feedback.
>Later, Juan.
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2019-06-12 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 3:08 [Qemu-devel] [PATCH 0/2] migration/xbzrle: make xbzrle_encode_buffer little easier Wei Yang
2019-06-10 3:08 ` [Qemu-devel] [PATCH 1/2] cutils: remove one unnecessary pointer operation Wei Yang
2019-06-11 17:49 ` Dr. David Alan Gilbert
2019-06-11 22:10 ` Wei Yang
2019-06-12 10:17 ` Juan Quintela
2019-06-10 3:08 ` [Qemu-devel] [PATCH 2/2] migration/xbzrle: make xbzrle_encode_buffer little easier to read Wei Yang
2019-06-11 17:59 ` Dr. David Alan Gilbert
2019-06-12 0:33 ` Wei Yang
2019-06-12 1:30 ` Wei Yang
2019-06-12 10:29 ` Juan Quintela
2019-06-12 15:02 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612150227.ycohdktaf4yconpl@master \
--to=richard.weiyang@gmail.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).