From: Stefan Hajnoczi <stefanha@gmail.com>
To: Martin Ichilevici de Oliveira <martin.i.oliveira@gmail.com>
Cc: javier@javigon.com, qemu-devel@nongnu.org,
Stephen Bates <sbates@raithlin.com>
Subject: Re: [Qemu-devel] [PATCH] [RFC] Add a eBPF-capable PCIe device
Date: Fri, 14 Jun 2019 09:33:02 +0100 [thread overview]
Message-ID: <20190614083302.GA10957@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190603205826.2345-1-martin.i.oliveira@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Mon, Jun 03, 2019 at 02:58:26PM -0600, Martin Ichilevici de Oliveira wrote:
Thanks for sharing!
The bpf_ram accesses are unsafe. The guest can modify bpf_ram while the
device is accessing it. This is likely to cause security problems.
I think a model is required where the device copies in the program and
additional data before processing. This way the guest cannot modify it
while the device is executing the program.
Also, please validate inputs. The guest is untrusted. Offsets, sizes,
etc cannot be trusted and must be bounds-checked.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-06-14 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 20:58 [Qemu-devel] [PATCH] [RFC] Add a eBPF-capable PCIe device Martin Ichilevici de Oliveira
2019-06-14 8:33 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614083302.GA10957@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=javier@javigon.com \
--cc=martin.i.oliveira@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).