From: elohimes@gmail.com
To: mst@redhat.com, groug@kaod.org
Cc: qemu-devel@nongnu.org, Xie Yongji <xieyongji@baidu.com>,
dgilbert@redhat.com, ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/5] virtio: fix some issues of "started" and "start_on_kick" flag
Date: Fri, 14 Jun 2019 17:31:16 +0800 [thread overview]
Message-ID: <20190614093121.5580-1-xieyongji@baidu.com> (raw)
From: Xie Yongji <xieyongji@baidu.com>
We introduced two flags "started" and "start_on_kick" to indicate virtio
device's state before. But there still are some problems with them. So
we try to fixup them in this patchset.
The patch 1 introduces a "use-started" property to avoid a migration
issue under Greg Kurz's suggestion [1].
The patch 2 set "start_on_kick" flag for legacy devices.
The patch 3 fixes a regression bug that old guest is not able to boot with
vhost-user-blk device.
The patch 4,5 fix some problems with "started" and "start_on_kick" flag.
[1] https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg06247.html
v3:
- change the order of patches
- Also disable "use-started" property by hw_compat_4_0
v2:
- Recalculate "start_on_kick" flag after migration instead of migrating
it
- Set "start_on_kick" flag for legacy devices
- Avoid setting "started" flag when "use_started" property is true
- Set "use_started" to false by hw_compat_4_0_1 instead of hw_compat_4_0
Xie Yongji (5):
virtio: add "use-started" property
virtio: Set "start_on_kick" for legacy devices
virtio: Set "start_on_kick" on virtio_set_features()
virtio: Make sure we get correct state of device on
handle_aio_output()
virtio: Don't change "started" flag on virtio_vmstate_change()
hw/block/vhost-user-blk.c | 4 +--
hw/core/machine.c | 8 ++++--
hw/virtio/virtio.c | 53 ++++++++++++++++++++++----------------
include/hw/virtio/virtio.h | 23 ++++++++++++++++-
4 files changed, 61 insertions(+), 27 deletions(-)
--
2.17.1
next reply other threads:[~2019-06-14 9:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 9:31 elohimes [this message]
2019-06-14 9:31 ` [Qemu-devel] [PATCH v3 1/5] virtio: add "use-started" property elohimes
2019-06-14 11:44 ` Greg Kurz
2019-06-17 2:14 ` Yongji Xie
2019-06-17 5:20 ` Greg Kurz
2019-06-17 6:04 ` Yongji Xie
2019-06-22 15:51 ` Greg Kurz
2019-06-24 9:44 ` Yongji Xie
2019-06-14 9:31 ` [Qemu-devel] [PATCH v3 2/5] virtio: Set "start_on_kick" for legacy devices elohimes
2019-06-16 17:27 ` Greg Kurz
2019-06-14 9:31 ` [Qemu-devel] [PATCH v3 3/5] virtio: Set "start_on_kick" on virtio_set_features() elohimes
2019-06-14 9:31 ` [Qemu-devel] [PATCH v3 4/5] virtio: Make sure we get correct state of device on handle_aio_output() elohimes
2019-06-14 9:31 ` [Qemu-devel] [PATCH v3 5/5] virtio: Don't change "started" flag on virtio_vmstate_change() elohimes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614093121.5580-1-xieyongji@baidu.com \
--to=elohimes@gmail.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xieyongji@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).