qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: elohimes@gmail.com
To: mst@redhat.com, groug@kaod.org
Cc: qemu-devel@nongnu.org, Xie Yongji <xieyongji@baidu.com>,
	dgilbert@redhat.com, ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH v3 4/5] virtio: Make sure we get correct state of device on handle_aio_output()
Date: Fri, 14 Jun 2019 17:31:20 +0800	[thread overview]
Message-ID: <20190614093121.5580-5-xieyongji@baidu.com> (raw)
In-Reply-To: <20190614093121.5580-1-xieyongji@baidu.com>

From: Xie Yongji <xieyongji@baidu.com>

We should set the flags: "start_on_kick" and "started" after we call
the kick functions (handle_aio_output() and handle_output()).

Signed-off-by: Xie Yongji <xieyongji@baidu.com>
---
 hw/virtio/virtio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 034320d277..b4301f9e02 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -1571,10 +1571,10 @@ void virtio_queue_notify(VirtIODevice *vdev, int n)
         event_notifier_set(&vq->host_notifier);
     } else if (vq->handle_output) {
         vq->handle_output(vdev, vq);
-    }
 
-    if (unlikely(vdev->start_on_kick)) {
-        virtio_set_started(vdev, true);
+        if (unlikely(vdev->start_on_kick)) {
+            virtio_set_started(vdev, true);
+        }
     }
 }
 
-- 
2.17.1



  parent reply	other threads:[~2019-06-14  9:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14  9:31 [Qemu-devel] [PATCH v3 0/5] virtio: fix some issues of "started" and "start_on_kick" flag elohimes
2019-06-14  9:31 ` [Qemu-devel] [PATCH v3 1/5] virtio: add "use-started" property elohimes
2019-06-14 11:44   ` Greg Kurz
2019-06-17  2:14     ` Yongji Xie
2019-06-17  5:20       ` Greg Kurz
2019-06-17  6:04         ` Yongji Xie
2019-06-22 15:51           ` Greg Kurz
2019-06-24  9:44             ` Yongji Xie
2019-06-14  9:31 ` [Qemu-devel] [PATCH v3 2/5] virtio: Set "start_on_kick" for legacy devices elohimes
2019-06-16 17:27   ` Greg Kurz
2019-06-14  9:31 ` [Qemu-devel] [PATCH v3 3/5] virtio: Set "start_on_kick" on virtio_set_features() elohimes
2019-06-14  9:31 ` elohimes [this message]
2019-06-14  9:31 ` [Qemu-devel] [PATCH v3 5/5] virtio: Don't change "started" flag on virtio_vmstate_change() elohimes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190614093121.5580-5-xieyongji@baidu.com \
    --to=elohimes@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xieyongji@baidu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).