* [Qemu-devel] [PATCH] iotests: Hide timestamps for skipped tests
@ 2019-06-13 18:37 Max Reitz
2019-06-13 20:03 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Max Reitz @ 2019-06-13 18:37 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, qemu-devel, Max Reitz
Currently, the "thistime" variable is not reinitialized on every loop
iteration. This leads to tests that do not yield a run time (because
they failed or were skipped) printing the run time of the previous test
that did. Fix that by reinitializing "thistime" for every test.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/check | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 44ebf24080..f925606cc5 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -773,6 +773,7 @@ do
printdiff=false # show diff to reference output?
status="" # test result summary
results="" # test result details
+ thistime="" # time the test took
if [ -n "$TESTS_REMAINING_LOG" ] ; then
sed -e "s/$seq//" -e 's/ / /' -e 's/^ *//' $TESTS_REMAINING_LOG > $TESTS_REMAINING_LOG.tmp
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] iotests: Hide timestamps for skipped tests
2019-06-13 18:37 [Qemu-devel] [PATCH] iotests: Hide timestamps for skipped tests Max Reitz
@ 2019-06-13 20:03 ` Eric Blake
2019-06-14 3:42 ` Philippe Mathieu-Daudé
2019-06-14 9:53 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2019-06-13 20:03 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 1197 bytes --]
On 6/13/19 1:37 PM, Max Reitz wrote:
> Currently, the "thistime" variable is not reinitialized on every loop
> iteration. This leads to tests that do not yield a run time (because
> they failed or were skipped) printing the run time of the previous test
> that did. Fix that by reinitializing "thistime" for every test.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/check | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index 44ebf24080..f925606cc5 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -773,6 +773,7 @@ do
> printdiff=false # show diff to reference output?
> status="" # test result summary
> results="" # test result details
> + thistime="" # time the test took
>
> if [ -n "$TESTS_REMAINING_LOG" ] ; then
> sed -e "s/$seq//" -e 's/ / /' -e 's/^ *//' $TESTS_REMAINING_LOG > $TESTS_REMAINING_LOG.tmp
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Hide timestamps for skipped tests
2019-06-13 18:37 [Qemu-devel] [PATCH] iotests: Hide timestamps for skipped tests Max Reitz
2019-06-13 20:03 ` Eric Blake
@ 2019-06-14 3:42 ` Philippe Mathieu-Daudé
2019-06-14 9:53 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-06-14 3:42 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
On 6/13/19 8:37 PM, Max Reitz wrote:
> Currently, the "thistime" variable is not reinitialized on every loop
> iteration. This leads to tests that do not yield a run time (because
> they failed or were skipped) printing the run time of the previous test
> that did. Fix that by reinitializing "thistime" for every test.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/check | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index 44ebf24080..f925606cc5 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -773,6 +773,7 @@ do
> printdiff=false # show diff to reference output?
> status="" # test result summary
> results="" # test result details
> + thistime="" # time the test took
>
> if [ -n "$TESTS_REMAINING_LOG" ] ; then
> sed -e "s/$seq//" -e 's/ / /' -e 's/^ *//' $TESTS_REMAINING_LOG > $TESTS_REMAINING_LOG.tmp
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Hide timestamps for skipped tests
2019-06-13 18:37 [Qemu-devel] [PATCH] iotests: Hide timestamps for skipped tests Max Reitz
2019-06-13 20:03 ` Eric Blake
2019-06-14 3:42 ` Philippe Mathieu-Daudé
@ 2019-06-14 9:53 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2019-06-14 9:53 UTC (permalink / raw)
To: Max Reitz; +Cc: qemu-devel, qemu-block
Am 13.06.2019 um 20:37 hat Max Reitz geschrieben:
> Currently, the "thistime" variable is not reinitialized on every loop
> iteration. This leads to tests that do not yield a run time (because
> they failed or were skipped) printing the run time of the previous test
> that did. Fix that by reinitializing "thistime" for every test.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-14 9:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-13 18:37 [Qemu-devel] [PATCH] iotests: Hide timestamps for skipped tests Max Reitz
2019-06-13 20:03 ` Eric Blake
2019-06-14 3:42 ` Philippe Mathieu-Daudé
2019-06-14 9:53 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).