From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C868C31E4B for ; Fri, 14 Jun 2019 10:16:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38C6C20665 for ; Fri, 14 Jun 2019 10:16:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38C6C20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbjG4-00021M-FK for qemu-devel@archiver.kernel.org; Fri, 14 Jun 2019 06:16:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48825) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbj88-0004EA-Kx for qemu-devel@nongnu.org; Fri, 14 Jun 2019 06:08:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbj87-0000im-Lw for qemu-devel@nongnu.org; Fri, 14 Jun 2019 06:08:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56214) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbj85-0000hJ-BT; Fri, 14 Jun 2019 06:08:17 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9520866967; Fri, 14 Jun 2019 10:08:16 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C8E91001B1B; Fri, 14 Jun 2019 10:08:06 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Fri, 14 Jun 2019 12:07:15 +0200 Message-Id: <20190614100718.14019-7-philmd@redhat.com> In-Reply-To: <20190614100718.14019-1-philmd@redhat.com> References: <20190614100718.14019-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 14 Jun 2019 10:08:16 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 6/9] configure: Link test before auto-enabling OpenGL libraries X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Thomas Huth , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev , Bharata B Rao , Gerd Hoffmann , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Niels de Vos Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Similarly to commit a73e82ef912, test the libraries link correctly before considering them as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-lm32-softmmu [...] LINK lm32-softmmu/qemu-system-lm32 /usr/bin/ld: cannot find -lepoxy /usr/bin/ld: cannot find -lgbm collect2: error: ld returned 1 exit status Makefile:204: recipe for target 'qemu-system-lm32' failed make[1]: *** [qemu-system-lm32] Error 1 $ fgrep epoxy config-host.mak OPENGL_LIBS=3D-lepoxy -ldl -lgbm -ldl $ lsb_release -cri Distributor ID: Ubuntu Release: 18.04 Codename: bionic Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configure | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 449dbd69ce..a3da5adf80 100755 --- a/configure +++ b/configure @@ -4133,11 +4133,21 @@ if test "$opengl" !=3D "no" ; then if $pkg_config $opengl_pkgs; then opengl_cflags=3D"$($pkg_config --cflags $opengl_pkgs)" opengl_libs=3D"$($pkg_config --libs $opengl_pkgs)" - opengl=3Dyes - if test "$gtk" =3D "yes" && $pkg_config --exists "$gtkpackage >=3D 3= .16"; then - gtk_gl=3D"yes" + # Packaging for the static libraries is not always correct. + # At least ubuntu 18.04 ships only shared libraries. + write_c_skeleton + if ! compile_prog "$opengl_cflags" "$opengl_libs" ; then + if test "$opengl" =3D "yes" ; then + error_exit "opengl check failed." + fi + opengl=3Dno + else + opengl=3Dyes + if test "$gtk" =3D "yes" && $pkg_config --exists "$gtkpackage >=3D= 3.16"; then + gtk_gl=3D"yes" + fi + QEMU_CFLAGS=3D"$QEMU_CFLAGS $opengl_cflags" fi - QEMU_CFLAGS=3D"$QEMU_CFLAGS $opengl_cflags" else if test "$opengl" =3D "yes" ; then feature_not_found "opengl" "Please install opengl (mesa) devel pkg= s: $opengl_pkgs" --=20 2.20.1