From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 1/2] s390x/cpumodel: Rework CPU feature definition
Date: Fri, 14 Jun 2019 13:47:35 +0200 [thread overview]
Message-ID: <20190614134735.53398810.cohuck@redhat.com> (raw)
In-Reply-To: <20190612132526.8905-2-david@redhat.com>
On Wed, 12 Jun 2019 15:25:25 +0200
David Hildenbrand <david@redhat.com> wrote:
> Let's define features at a single spot and make it less error prone to
> define new features.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/cpu_features.c | 352 +-------------------------
> target/s390x/cpu_features_def.h | 352 +-------------------------
> target/s390x/cpu_features_def.inc.h | 369 ++++++++++++++++++++++++++++
> 3 files changed, 386 insertions(+), 687 deletions(-)
> create mode 100644 target/s390x/cpu_features_def.inc.h
Yes, let's get rid of the need to define this in two places.
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-06-14 12:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 13:25 [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition David Hildenbrand
2019-06-12 13:25 ` [Qemu-devel] [PATCH v1 1/2] " David Hildenbrand
2019-06-13 11:26 ` Janosch Frank
2019-06-14 11:47 ` Cornelia Huck [this message]
2019-06-12 13:25 ` [Qemu-devel] [PATCH v1 2/2] s390x/cpumodel: Prepend KDSA features with "KDSA" David Hildenbrand
2019-06-13 11:27 ` Janosch Frank
2019-06-14 11:48 ` Cornelia Huck
2019-06-12 15:39 ` [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition no-reply
2019-06-14 11:49 ` Cornelia Huck
2019-06-14 11:54 ` David Hildenbrand
2019-06-14 12:10 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614134735.53398810.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).