From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB583C31E44 for ; Fri, 14 Jun 2019 11:55:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8720621473 for ; Fri, 14 Jun 2019 11:55:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8720621473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbknO-0001xe-QL for qemu-devel@archiver.kernel.org; Fri, 14 Jun 2019 07:55:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46445) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbkiH-0005wS-6Y for qemu-devel@nongnu.org; Fri, 14 Jun 2019 07:49:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbkiC-0001QB-Lx for qemu-devel@nongnu.org; Fri, 14 Jun 2019 07:49:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56546) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbkiC-0001Mb-ER; Fri, 14 Jun 2019 07:49:40 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2227830832C5; Fri, 14 Jun 2019 11:49:38 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id B85517839B; Fri, 14 Jun 2019 11:49:34 +0000 (UTC) Date: Fri, 14 Jun 2019 13:49:32 +0200 From: Cornelia Huck To: David Hildenbrand Message-ID: <20190614134932.3df92945.cohuck@redhat.com> In-Reply-To: <20190612132526.8905-1-david@redhat.com> References: <20190612132526.8905-1-david@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 14 Jun 2019 11:49:38 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Janosch Frank , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 12 Jun 2019 15:25:24 +0200 David Hildenbrand wrote: > Rework the feature initialization, making it harder to make mistakes. > While at it, rename the enum names of the KDSA features. > > David Hildenbrand (2): > s390x/cpumodel: Rework CPU feature definition > s390x/cpumodel: Prepend KDSA features with "KDSA" > > target/s390x/cpu_features.c | 352 +------------------------- > target/s390x/cpu_features_def.h | 352 +------------------------- > target/s390x/cpu_features_def.inc.h | 369 ++++++++++++++++++++++++++++ > target/s390x/gen-features.c | 30 +-- > 4 files changed, 401 insertions(+), 702 deletions(-) > create mode 100644 target/s390x/cpu_features_def.inc.h > Looks good to me. Do you want to take it via your tree?