From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
To: Eric Blake <eblake@redhat.com>
Cc: john.g.johnson@oracle.com, jag.raman@oracle.com,
konrad.wilk@oracle.com, qemu-devel@nongnu.org,
ross.lagerwall@citrix.com, liran.alon@oracle.com,
stefanha@redhat.com, marcandre.lureau@redhat.com,
imammedo@redhat.com, kanth.ghatraju@oracle.com
Subject: Re: [Qemu-devel] [RFC PATCH v2 24/35] multi-process: add qdev_proxy_add to create proxy devices
Date: Mon, 17 Jun 2019 12:47:39 -0700 [thread overview]
Message-ID: <20190617194739.GB24278@heatpipe> (raw)
In-Reply-To: <c8e6cb54-4b37-1452-c215-a9e071000635@redhat.com>
On Mon, Jun 17, 2019 at 02:22:08PM -0500, Eric Blake wrote:
> On 6/17/19 1:16 PM, elena.ufimtseva@oracle.com wrote:
> > From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> >
> > This is handled while parsing the command line options.
> > The parsed options are being sent to remote process
> > as the messgaes containing JSON strings.
>
> s/messgaes/messages/
>
> >
> > Changes in v2:
> > - parse socket and command suboptions of drive/device commands;
>
> The changelog paragraph belongs...
>
> >
> > Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
> > Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
> > Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> > ---
>
> ...here, after the --- divider. It is useful to reviewers, but gets
> stripped by 'git am' when the maintainer applies the series. A year from
> now, we won't care how many iterations the patches went through on list,
> only the one version that got committed to git.
>
That one slipped trough with this, will fix.
> > include/hw/proxy/qemu-proxy.h | 7 ++
> > include/monitor/qdev.h | 5 +
> > qdev-monitor.c | 166 ++++++++++++++++++++++++++++++++++
> > 3 files changed, 178 insertions(+)
> >
>
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
>
prev parent reply other threads:[~2019-06-17 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 18:16 [Qemu-devel] [RFC PATCH v2 24/35] multi-process: add qdev_proxy_add to create proxy devices elena.ufimtseva
2019-06-17 19:22 ` Eric Blake
2019-06-17 19:47 ` Elena Ufimtseva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617194739.GB24278@heatpipe \
--to=elena.ufimtseva@oracle.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=kanth.ghatraju@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=liran.alon@oracle.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.lagerwall@citrix.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).