qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/5] pci: designware: Update MSI mapping when MSI address changes
Date: Mon, 17 Jun 2019 21:26:45 -0400	[thread overview]
Message-ID: <20190617212637-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190416013902.4941-5-andrew.smirnov@gmail.com>

On Mon, Apr 15, 2019 at 06:39:01PM -0700, Andrey Smirnov wrote:
> MSI mapping needs to be update when MSI address changes, so add the
> code to do so.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: qemu-devel@nongnu.org
> Cc: qemu-arm@nongnu.org

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci-host/designware.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c
> index 6affe823c0..e80facc4a0 100644
> --- a/hw/pci-host/designware.c
> +++ b/hw/pci-host/designware.c
> @@ -289,11 +289,13 @@ static void designware_pcie_root_config_write(PCIDevice *d, uint32_t address,
>      case DESIGNWARE_PCIE_MSI_ADDR_LO:
>          root->msi.base &= 0xFFFFFFFF00000000ULL;
>          root->msi.base |= val;
> +        designware_pcie_root_update_msi_mapping(root);
>          break;
>  
>      case DESIGNWARE_PCIE_MSI_ADDR_HI:
>          root->msi.base &= 0x00000000FFFFFFFFULL;
>          root->msi.base |= (uint64_t)val << 32;
> +        designware_pcie_root_update_msi_mapping(root);
>          break;
>  
>      case DESIGNWARE_PCIE_MSI_INTR0_ENABLE:
> -- 
> 2.20.1


  parent reply	other threads:[~2019-06-18  1:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16  1:38 [Qemu-devel] [PATCH 0/5] Various i.MX7 fixes Andrey Smirnov
2019-04-16  1:38 ` Andrey Smirnov
2019-04-16  1:38 ` [Qemu-devel] [PATCH 1/5] i.mx7d: Add no-op/unimplemented APBH DMA module Andrey Smirnov
2019-04-16  1:38   ` Andrey Smirnov
2019-06-18  5:15   ` Philippe Mathieu-Daudé
2019-04-16  1:38 ` [Qemu-devel] [PATCH 2/5] i.mx7d: Add no-op/unimplemented PCIE PHY IP block Andrey Smirnov
2019-04-16  1:38   ` Andrey Smirnov
2019-06-18  5:20   ` Philippe Mathieu-Daudé
2019-04-16  1:39 ` [Qemu-devel] [PATCH 3/5] pci: designware: Update MSI mapping unconditionally Andrey Smirnov
2019-04-16  1:39   ` Andrey Smirnov
2019-06-18  1:26   ` Michael S. Tsirkin
2019-07-01 11:56   ` Peter Maydell
2019-04-16  1:39 ` [Qemu-devel] [PATCH 4/5] pci: designware: Update MSI mapping when MSI address changes Andrey Smirnov
2019-04-16  1:39   ` Andrey Smirnov
2019-06-18  1:26   ` Michael S. Tsirkin [this message]
2019-07-01 11:56   ` Peter Maydell
2019-04-16  1:39 ` [Qemu-devel] [PATCH 5/5] i.mx7d: pci: Update PCI IRQ mapping to match HW Andrey Smirnov
2019-04-16  1:39   ` Andrey Smirnov
2019-07-01 12:01   ` Peter Maydell
2019-06-18  0:27 ` [Qemu-devel] [PATCH 0/5] Various i.MX7 fixes Andrey Smirnov
2019-07-01 12:12   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190617212637-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).