qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: elena.ufimtseva@oracle.com
Cc: john.g.johnson@oracle.com, jag.raman@oracle.com, mst@redhat.com,
	konrad.wilk@oracle.com, qemu-devel@nongnu.org,
	ross.lagerwall@citrix.com, liran.alon@oracle.com,
	stefanha@redhat.com, kanth.ghatraju@oracle.com
Subject: Re: [Qemu-devel] [RFC PATCH v2 09/35] multi-process: setup PCI host bridge for remote device
Date: Tue, 18 Jun 2019 08:53:21 +0200	[thread overview]
Message-ID: <20190618065321.f55peregolzan4iv@sirius.home.kraxel.org> (raw)
In-Reply-To: <20190617181539.29532-1-elena.ufimtseva@oracle.com>

On Mon, Jun 17, 2019 at 11:15:39AM -0700, elena.ufimtseva@oracle.com wrote:
> From: Jagannathan Raman <jag.raman@oracle.com>
> 
> PCI host bridge is setup for the remote device process. It is
> implemented using remote-pcihost object. It is an extension of the PCI
> host bridge setup by QEMU.
> Remote-pcihost configures a PCI bus which could be used by the remote
>  PCI device to latch on to.

Hmm, this (and at least the next two patches) look like you just fake
everything the device emulation needs in the remote process.

I doubt this is a good long-term plan.

IIRC there was some discussion on the last kvm forum on the idea to
re-use the vfio API for pci emulation in a separate process, i.e. create
something like vfio-user.  Have you considered this?

Sure, the lsi host adapter will probably need some refactoring so the
code can compiled into both qemu and a vfio-user server.  But that way
the chance that this can be maintained long-term without too much
headache is much higher.

A small, well-defined interface will also make it easier to re-write the
device emulation in another language like rust or go.

The current patch series feels more like a early proof-of-concept than
something mergeable ...

cheers,
  Gerd



      reply	other threads:[~2019-06-18  6:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 18:15 [Qemu-devel] [RFC PATCH v2 09/35] multi-process: setup PCI host bridge for remote device elena.ufimtseva
2019-06-18  6:53 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190618065321.f55peregolzan4iv@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=jag.raman@oracle.com \
    --cc=john.g.johnson@oracle.com \
    --cc=kanth.ghatraju@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=liran.alon@oracle.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ross.lagerwall@citrix.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).