From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-ppc@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug
Date: Tue, 18 Jun 2019 18:41:48 +1000 [thread overview]
Message-ID: <20190618084148.GB3673@umbus.BigPond> (raw)
In-Reply-To: <156078063349.435533.12283208810037409702.stgit@bahia.lan>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Mon, Jun 17, 2019 at 04:10:33PM +0200, Greg Kurz wrote:
> So that no one is tempted to drop that code, which is never called
> for cold plugged CPUs.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Applied, thanks.
> ---
> hw/intc/xics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
> index 8535e583dd41..faa976e2f8a8 100644
> --- a/hw/intc/xics.c
> +++ b/hw/intc/xics.c
> @@ -363,6 +363,7 @@ static void icp_realize(DeviceState *dev, Error **errp)
> return;
> }
>
> + /* Connect the presenter to the VCPU (required for CPU hotplug) */
> if (kvm_irqchip_in_kernel()) {
> icp_kvm_realize(dev, &err);
> if (err) {
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-06-18 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 14:10 [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug Greg Kurz
2019-06-17 14:18 ` Cédric Le Goater
2019-06-18 8:41 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618084148.GB3673@umbus.BigPond \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).