* [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug
@ 2019-06-17 14:10 Greg Kurz
2019-06-17 14:18 ` Cédric Le Goater
2019-06-18 8:41 ` David Gibson
0 siblings, 2 replies; 3+ messages in thread
From: Greg Kurz @ 2019-06-17 14:10 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-ppc, Cédric Le Goater, qemu-devel
So that no one is tempted to drop that code, which is never called
for cold plugged CPUs.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
hw/intc/xics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index 8535e583dd41..faa976e2f8a8 100644
--- a/hw/intc/xics.c
+++ b/hw/intc/xics.c
@@ -363,6 +363,7 @@ static void icp_realize(DeviceState *dev, Error **errp)
return;
}
+ /* Connect the presenter to the VCPU (required for CPU hotplug) */
if (kvm_irqchip_in_kernel()) {
icp_kvm_realize(dev, &err);
if (err) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug
2019-06-17 14:10 [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug Greg Kurz
@ 2019-06-17 14:18 ` Cédric Le Goater
2019-06-18 8:41 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2019-06-17 14:18 UTC (permalink / raw)
To: Greg Kurz, David Gibson; +Cc: qemu-ppc, qemu-devel
On 17/06/2019 16:10, Greg Kurz wrote:
> So that no one is tempted to drop that code, which is never called
> for cold plugged CPUs.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug
2019-06-17 14:10 [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug Greg Kurz
2019-06-17 14:18 ` Cédric Le Goater
@ 2019-06-18 8:41 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2019-06-18 8:41 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-ppc, Cédric Le Goater, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Mon, Jun 17, 2019 at 04:10:33PM +0200, Greg Kurz wrote:
> So that no one is tempted to drop that code, which is never called
> for cold plugged CPUs.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Applied, thanks.
> ---
> hw/intc/xics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
> index 8535e583dd41..faa976e2f8a8 100644
> --- a/hw/intc/xics.c
> +++ b/hw/intc/xics.c
> @@ -363,6 +363,7 @@ static void icp_realize(DeviceState *dev, Error **errp)
> return;
> }
>
> + /* Connect the presenter to the VCPU (required for CPU hotplug) */
> if (kvm_irqchip_in_kernel()) {
> icp_kvm_realize(dev, &err);
> if (err) {
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-18 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-17 14:10 [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug Greg Kurz
2019-06-17 14:18 ` Cédric Le Goater
2019-06-18 8:41 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).