From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19463C31E51 for ; Tue, 18 Jun 2019 11:35:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6604208E4 for ; Tue, 18 Jun 2019 11:35:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6604208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55770 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdCOk-00015J-Nf for qemu-devel@archiver.kernel.org; Tue, 18 Jun 2019 07:35:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46389) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdCNb-0000ZJ-T7 for qemu-devel@nongnu.org; Tue, 18 Jun 2019 07:34:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdCNa-0000R4-Pv for qemu-devel@nongnu.org; Tue, 18 Jun 2019 07:34:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50760) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hdCNa-0000Po-K1 for qemu-devel@nongnu.org; Tue, 18 Jun 2019 07:34:22 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF71B30872DE; Tue, 18 Jun 2019 11:34:20 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC8F15BBBD; Tue, 18 Jun 2019 11:34:14 +0000 (UTC) Date: Tue, 18 Jun 2019 13:34:10 +0200 From: Igor Mammedov To: Eduardo Habkost Message-ID: <20190618133410.18b93bcd@redhat.com> In-Reply-To: <20190617162700.GC19178@habkost.net> References: <20180202182326.GB22556@localhost.localdomain> <20180205122235.03fdeaad@redhat.com> <20180205135401.GA3300@localhost.localdomain> <20180205154202.7d1269a9@redhat.com> <20180205224205.GA3291@localhost.localdomain> <20180206154320.288acdc2@redhat.com> <62d7649e-e85d-43a2-2df8-85e2a0953e89@redhat.com> <20190617170106.48d776ca@redhat.com> <0a31228d-4d32-2c54-649b-6aef9953fffc@redhat.com> <20190617173343.68e3c9ec@redhat.com> <20190617162700.GC19178@habkost.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 18 Jun 2019 11:34:20 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcel@redhat.com, peter.maydell@linaro.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , qemu-devel@nongnu.org, alistair23@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 17 Jun 2019 13:27:00 -0300 Eduardo Habkost wrote: > On Mon, Jun 17, 2019 at 05:33:43PM +0200, Igor Mammedov wrote: > > On Mon, 17 Jun 2019 17:15:21 +0200 > > Philippe Mathieu-Daud=C3=A9 wrote: =20 > [...] > > > Yes. Eduardo and you should write some lines to explain this, and then > > > we will follow :) =20 > > Unfortunately I don't recall details anymore. One could check out all > > implementations of class_by_name callbacks to find out current state. = =20 >=20 > See this message for a summary of existing class_by_name quirks: >=20 > https://www.mail-archive.com/qemu-devel@nongnu.org/msg615503.html > Date: Wed, 08 May 2019 10:34:44 +0200 > Message-ID: <877eb173a3.fsf@dusky.pond.sub.org> > Subject: Re: [Qemu-devel] [PATCH 0/7] Delete 16 *_cpu_class_by_name() f= unctions >=20 > I'm unsure about Igor's suggestion to get rid of CPU model names > and use only QOM type names in external interfaces. In either > case, we can still simplify the rules rules and reduce the amount > of arch-specific code. as far as we have cpu_class_by_name, we have to watch over that new patches/targets won't add some custom handling/fallbac/whatnot. On contrary -device works just with type names for all devices, applying the same to -cpu which is basically translator model->type[,-global type.foo,...] would be consistent with -device and less confusing for everyone (not counting significant code reduction). It would certainly simplify contributing new targets as contributor won't have to care about cpu model naming and do something about it. This option wasn't considered before because we didn't have deprecation back then, but now it opens possibility to simplify qemu and consolidate naming. (we probably would be able to fold '-cpu help' into '-device help' as well).