From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93258C31E5B for ; Tue, 18 Jun 2019 22:55:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68F4A2063F for ; Tue, 18 Jun 2019 22:55:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68F4A2063F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33994 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdN0Y-0003k7-Ih for qemu-devel@archiver.kernel.org; Tue, 18 Jun 2019 18:55:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56778) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdMzN-0003Gy-79 for qemu-devel@nongnu.org; Tue, 18 Jun 2019 18:54:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdMzM-0002u6-6K for qemu-devel@nongnu.org; Tue, 18 Jun 2019 18:54:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52864) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hdMzM-0002t6-11 for qemu-devel@nongnu.org; Tue, 18 Jun 2019 18:54:04 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 47B1B3082E71; Tue, 18 Jun 2019 22:54:02 +0000 (UTC) Received: from localhost (ovpn-116-76.gru2.redhat.com [10.97.116.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0C9719C69; Tue, 18 Jun 2019 22:54:01 +0000 (UTC) Date: Tue, 18 Jun 2019 19:54:00 -0300 From: Eduardo Habkost To: Roman Kagan Message-ID: <20190618225400.GL19178@habkost.net> References: <20190618110659.14744-1-rkagan@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190618110659.14744-1-rkagan@virtuozzo.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 18 Jun 2019 22:54:03 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] i386: make 'hv-spinlocks' a regular uint32 property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Vitaly Kuznetsov , Richard Henderson , "qemu-devel@nongnu.org" , Vadim Rozenfeld Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 18, 2019 at 11:07:06AM +0000, Roman Kagan wrote: > X86CPU.hv-spinlocks is a uint32 property that has a special setter > validating the value to be no less than 0xFFF and no bigger than > UINT_MAX. The latter check is redundant; as for the former, there > appears to be no reason to prohibit the user from setting it to a lower > value. > > So nuke the dedicated getter/setter pair and convert 'hv-spinlocks' to a > regular uint32 property. > > Signed-off-by: Roman Kagan Reviewed-by: Eduardo Habkost Queued on x86-next. Thanks! -- Eduardo