From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A132C43613 for ; Thu, 20 Jun 2019 08:56:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D0982084A for ; Thu, 20 Jun 2019 08:56:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D0982084A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdss4-0006ds-Qw for qemu-devel@archiver.kernel.org; Thu, 20 Jun 2019 04:56:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36172) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdsjF-0007SI-Tc for qemu-devel@nongnu.org; Thu, 20 Jun 2019 04:47:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdsY2-0007ul-Tz for qemu-devel@nongnu.org; Thu, 20 Jun 2019 04:36:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50334) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hdsY1-0007sf-Am for qemu-devel@nongnu.org; Thu, 20 Jun 2019 04:35:57 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 71625DD9F4 for ; Thu, 20 Jun 2019 08:35:49 +0000 (UTC) Received: from redhat.com (ovpn-112-65.ams2.redhat.com [10.36.112.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5640C1001B17; Thu, 20 Jun 2019 08:35:46 +0000 (UTC) Date: Thu, 20 Jun 2019 09:35:43 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Message-ID: <20190620083543.GG25448@redhat.com> References: <20190619201050.19040-1-armbru@redhat.com> <20190619201050.19040-6-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190619201050.19040-6-armbru@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 20 Jun 2019 08:35:51 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 05/17] qom: Move QMP command handlers to qom/ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: kwolf@redhat.com, Paolo Bonzini , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 19, 2019 at 10:10:38PM +0200, Markus Armbruster wrote: > The handlers for qapi/qom.json's QMP commands are in > monitor/qmp-cmds.c. Move them to new qom/qom-qmp-cmds.c, where they > are covered by MAINTAINERS section QOM, just like qapi/qom.json. >=20 > Move along qmp_device_list_properties() even though it's specified in > qapi/qdev.json, because it's so similar to qmp_qom_list_properties(). >=20 > Cc: Paolo Bonzini > Cc: "Daniel P. Berrange" > Cc: Eduardo Habkost > Signed-off-by: Markus Armbruster > --- > monitor/qmp-cmds.c | 303 ------------------------------------------ > qom/Makefile.objs | 1 + > qom/qom-qmp-cmds.c | 323 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 324 insertions(+), 303 deletions(-) > create mode 100644 qom/qom-qmp-cmds.c Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|