From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C7BC43613 for ; Thu, 20 Jun 2019 18:01:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50E762089C for ; Thu, 20 Jun 2019 18:01:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50E762089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he1NH-0007vQ-4Q for qemu-devel@archiver.kernel.org; Thu, 20 Jun 2019 14:01:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34981) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he19Q-0007LJ-Tv for qemu-devel@nongnu.org; Thu, 20 Jun 2019 13:47:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1he103-0004ZL-2h for qemu-devel@nongnu.org; Thu, 20 Jun 2019 13:37:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41948) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1he102-0004VM-TQ for qemu-devel@nongnu.org; Thu, 20 Jun 2019 13:37:27 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C77030860A3; Thu, 20 Jun 2019 17:37:23 +0000 (UTC) Received: from localhost (ovpn-116-108.ams2.redhat.com [10.36.116.108]) by smtp.corp.redhat.com (Postfix) with ESMTP id 675191001B12; Thu, 20 Jun 2019 17:37:18 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Date: Thu, 20 Jun 2019 18:37:06 +0100 Message-Id: <20190620173709.14753-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 20 Jun 2019 17:37:23 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v5 0/3] virtio-scsi: restart DMA after iothread X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Paolo Bonzini , Fam Zheng , Stefan Hajnoczi , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" v5: * Plumbing vm change state handlers into DeviceClass/BusClass is a rathe= r large bug fix. Instead I've combined the previous priorities approach= with the observation from Kevin and Paolo that we really want to order by q= dev tree depth. The new qdev_add_vm_change_state_handler() API lets DeviceStates regis= ter callbacks that execute in qdev tree depth order. This solves the virtio-scsi bug since the virtio-scsi device's callback must complete = before its child scsi-disk's callback runs. Is this a good compromise for everyone? Stefan Hajnoczi (3): vl: add qemu_add_vm_change_state_handler_prio() qdev: add qdev_add_vm_change_state_handler() virtio-scsi: restart DMA after iothread hw/core/Makefile.objs | 1 + include/hw/qdev-core.h | 5 +++ include/sysemu/sysemu.h | 2 + hw/core/vm-change-state-handler.c | 61 +++++++++++++++++++++++++++++++ hw/scsi/scsi-bus.c | 4 +- hw/virtio/virtio.c | 4 +- vl.c | 59 ++++++++++++++++++++++++------ 7 files changed, 120 insertions(+), 16 deletions(-) create mode 100644 hw/core/vm-change-state-handler.c --=20 2.21.0