From: vandersonmr <vandersonmr2@gmail.com>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
vandersonmr <vandersonmr2@gmail.com>,
Laurent Vivier <laurent@vivier.eu>
Subject: [Qemu-devel] [PATCH v2 4/4] adding -d hot_tbs:limit command line option
Date: Mon, 24 Jun 2019 02:54:42 -0300 [thread overview]
Message-ID: <20190624055442.2973-5-vandersonmr2@gmail.com> (raw)
In-Reply-To: <20190624055442.2973-1-vandersonmr2@gmail.com>
add option to dump the N most hot TB blocks.
-d hot_tbs:N
Signed-off-by: vandersonmr <vandersonmr2@gmail.com>
---
include/qemu/log-for-trace.h | 2 ++
linux-user/exit.c | 3 +++
util/log.c | 9 +++++++++
3 files changed, 14 insertions(+)
diff --git a/include/qemu/log-for-trace.h b/include/qemu/log-for-trace.h
index 2f0a5b080e..d65eb83037 100644
--- a/include/qemu/log-for-trace.h
+++ b/include/qemu/log-for-trace.h
@@ -21,6 +21,8 @@
/* Private global variable, don't use */
extern int qemu_loglevel;
+extern int32_t max_num_hot_tbs_to_dump;
+
#define LOG_TRACE (1 << 15)
/* Returns true if a bit is set in the current loglevel mask */
diff --git a/linux-user/exit.c b/linux-user/exit.c
index bdda720553..08b86dfd61 100644
--- a/linux-user/exit.c
+++ b/linux-user/exit.c
@@ -28,6 +28,9 @@ extern void __gcov_dump(void);
void preexit_cleanup(CPUArchState *env, int code)
{
+ if (qemu_loglevel_mask(CPU_LOG_HOT_TBS)) {
+ tb_dump_exec_freq(max_num_hot_tbs_to_dump);
+ }
#ifdef TARGET_GPROF
_mcleanup();
#endif
diff --git a/util/log.c b/util/log.c
index 1d1b33f7d9..e71c663143 100644
--- a/util/log.c
+++ b/util/log.c
@@ -30,6 +30,7 @@ FILE *qemu_logfile;
int qemu_loglevel;
static int log_append = 0;
static GArray *debug_regions;
+int32_t max_num_hot_tbs_to_dump;
/* Return the number of characters emitted. */
int qemu_log(const char *fmt, ...)
@@ -273,6 +274,9 @@ const QEMULogItem qemu_log_items[] = {
{ CPU_LOG_TB_NOCHAIN, "nochain",
"do not chain compiled TBs so that \"exec\" and \"cpu\" show\n"
"complete traces" },
+ { CPU_LOG_HOT_TBS, "hot_tbs(:limit)",
+ "show TBs (until given a limit) ordered by their hotness.\n"
+ "(if no limit is given, show all)" },
{ 0, NULL, NULL },
};
@@ -294,6 +298,11 @@ int qemu_str_to_log_mask(const char *str)
trace_enable_events((*tmp) + 6);
mask |= LOG_TRACE;
#endif
+ } else if (g_str_has_prefix(*tmp, "hot_tbs")) {
+ if (g_str_has_prefix(*tmp, "hot_tbs:") && (*tmp)[8] != '\0') {
+ max_num_hot_tbs_to_dump = atoi((*tmp) + 8);
+ }
+ mask |= CPU_LOG_HOT_TBS;
} else {
for (item = qemu_log_items; item->mask != 0; item++) {
if (g_str_equal(*tmp, item->name)) {
--
2.22.0
next prev parent reply other threads:[~2019-06-24 6:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 5:54 [Qemu-devel] [PATCH v2 0/4] dumping hot TBs vandersonmr
2019-06-24 5:54 ` [Qemu-devel] [PATCH v2 1/4] add and link a statistic struct to TBs vandersonmr
2019-06-24 15:06 ` Alex Bennée
2019-06-25 16:28 ` Alex Bennée
2019-06-25 17:37 ` Vanderson Martins do Rosario
2019-06-25 18:02 ` Alex Bennée
2019-06-26 11:05 ` Alex Bennée
2019-06-24 5:54 ` [Qemu-devel] [PATCH v2 2/4] Adding an optional tb execution counter vandersonmr
2019-06-25 9:51 ` Alex Bennée
2019-06-24 5:54 ` [Qemu-devel] [PATCH v2 3/4] Introduce dump of hot TBs vandersonmr
2019-06-25 10:38 ` Alex Bennée
2019-06-24 5:54 ` vandersonmr [this message]
2019-06-25 12:13 ` [Qemu-devel] [PATCH v2 4/4] adding -d hot_tbs:limit command line option Alex Bennée
2019-06-24 6:12 ` [Qemu-devel] [PATCH v2 0/4] dumping hot TBs no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624055442.2973-5-vandersonmr2@gmail.com \
--to=vandersonmr2@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).