From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69988C43613 for ; Mon, 24 Jun 2019 11:47:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 425A020674 for ; Mon, 24 Jun 2019 11:47:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 425A020674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfNRU-0001TW-9s for qemu-devel@archiver.kernel.org; Mon, 24 Jun 2019 07:47:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37259) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfNPn-00012R-Cg for qemu-devel@nongnu.org; Mon, 24 Jun 2019 07:45:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfNPl-0007yk-NA for qemu-devel@nongnu.org; Mon, 24 Jun 2019 07:45:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47254) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfNPl-0007tf-Gr for qemu-devel@nongnu.org; Mon, 24 Jun 2019 07:45:37 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 51A9687633 for ; Mon, 24 Jun 2019 11:45:28 +0000 (UTC) Received: from redhat.com (unknown [10.42.17.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66C405D717; Mon, 24 Jun 2019 11:45:26 +0000 (UTC) Date: Mon, 24 Jun 2019 12:45:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Message-ID: <20190624114524.GG17698@redhat.com> References: <20190619201050.19040-1-armbru@redhat.com> <20190619201050.19040-5-armbru@redhat.com> <6cca5383-fdd4-ab9b-d227-d2de1083d398@redhat.com> <87imsvs01m.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87imsvs01m.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 24 Jun 2019 11:45:28 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 04/17] qapi: Split qom.json and qdev.json off misc.json X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: kwolf@redhat.com, Paolo Bonzini , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jun 24, 2019 at 01:19:33PM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: >=20 > > On 19/06/19 22:10, Markus Armbruster wrote: > >> Move commands device-list-properties, device_add, device-del, and > >> event DEVICE_DELETED from misc.json to new qdev.json. qdev.json > >> remains uncovered by MAINTAINERS, like the rest of qdev. > > > > qdev should be added to either QOM or machine core. QOM would be fin= e > > for me as the (newly,self)-appointed maintainer. >=20 > Awesome! Daniel, Eduardo, any objections? >=20 > I figure these are the files to add: >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 63390eadb5..e2cb1726dd 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2033,12 +2033,18 @@ M: Paolo Bonzini > R: Daniel P. Berrange > R: Eduardo Habkost > S: Supported > +F: docs/qdev-device-use.txt > +F: hw/core/qdev* > +F: include/hw/qdev* > +F: include/monitor/qdev.h > F: include/qom/ > X: include/qom/cpu.h > +F: qdev-monitor.c > F: qom/ > X: qom/cpu.c > F: tests/check-qom-interface.c > F: tests/check-qom-proplist.c > +F: tests/test-qdev-global-props.c > =20 > QMP > M: Markus Armbruster For this addition Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|