From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
Jiri Denemark <jdenemar@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH 2/6] i386: Remove unused host_cpudef variable
Date: Tue, 25 Jun 2019 02:00:04 -0300 [thread overview]
Message-ID: <20190625050008.12789-3-ehabkost@redhat.com> (raw)
In-Reply-To: <20190625050008.12789-1-ehabkost@redhat.com>
The variable is completely unused, probably a leftover from
previous code clean up.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/i386/cpu.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 1bad957f6e..cf03dc786e 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3133,14 +3133,8 @@ static void max_x86_cpu_initfn(Object *obj)
char vendor[CPUID_VENDOR_SZ + 1] = { 0 };
char model_id[CPUID_MODEL_ID_SZ + 1] = { 0 };
int family, model, stepping;
- X86CPUDefinition host_cpudef = { };
- uint32_t eax = 0, ebx = 0, ecx = 0, edx = 0;
-
- host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx);
- x86_cpu_vendor_words2str(host_cpudef.vendor, ebx, edx, ecx);
host_vendor_fms(vendor, &family, &model, &stepping);
-
cpu_x86_fill_model_id(model_id);
object_property_set_str(OBJECT(cpu), vendor, "vendor", &error_abort);
--
2.18.0.rc1.1.g3f1ff2140
next prev parent reply other threads:[~2019-06-25 5:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 5:00 [Qemu-devel] [PATCH 0/6] x86 CPU model versioning Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 1/6] i386: Add x-force-features option for testing Eduardo Habkost
2019-06-25 5:00 ` Eduardo Habkost [this message]
2019-06-25 9:04 ` [Qemu-devel] [PATCH 2/6] i386: Remove unused host_cpudef variable Dr. David Alan Gilbert
2019-06-25 5:00 ` [Qemu-devel] [PATCH 3/6] qmp: Add "alias-of" field to query-cpu-definitions Eduardo Habkost
2019-06-25 16:15 ` Daniel P. Berrangé
2019-06-25 18:00 ` Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models Eduardo Habkost
2019-06-25 9:32 ` Dr. David Alan Gilbert
2019-06-25 13:40 ` Eduardo Habkost
2019-06-25 14:32 ` Dr. David Alan Gilbert
2019-06-25 14:53 ` Eduardo Habkost
2019-06-25 14:56 ` Dr. David Alan Gilbert
2019-06-25 16:05 ` Eduardo Habkost
2019-06-25 16:26 ` Daniel P. Berrangé
2019-06-25 17:59 ` Eduardo Habkost
2019-06-25 18:08 ` Daniel P. Berrangé
2019-06-25 18:11 ` Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 5/6] docs: Deprecate CPU model runnability guarantees Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 6/6] i386: Add Cascadelake-Server-4.1.1 CPU model Eduardo Habkost
2019-06-25 5:35 ` Tao Xu
2019-06-25 13:11 ` Eduardo Habkost
2019-06-25 5:15 ` [Qemu-devel] [PATCH 0/6] x86 CPU model versioning no-reply
2019-06-25 16:13 ` Daniel P. Berrangé
2019-06-25 18:11 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625050008.12789-3-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).