From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_HK_NAME_DR,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A70BAC48BD4 for ; Tue, 25 Jun 2019 13:02:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F2B7214DA for ; Tue, 25 Jun 2019 13:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F2B7214DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60008 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfl5a-0006Qc-Jc for qemu-devel@archiver.kernel.org; Tue, 25 Jun 2019 09:02:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49059) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfl2R-0005Kv-58 for qemu-devel@nongnu.org; Tue, 25 Jun 2019 08:59:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfl2N-0002Uw-8c for qemu-devel@nongnu.org; Tue, 25 Jun 2019 08:59:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47982) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfl2M-0002Su-AP for qemu-devel@nongnu.org; Tue, 25 Jun 2019 08:59:03 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2399D3082201 for ; Tue, 25 Jun 2019 12:58:59 +0000 (UTC) Received: from work-vm (ovpn-117-108.ams2.redhat.com [10.36.117.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74C525C236; Tue, 25 Jun 2019 12:58:54 +0000 (UTC) Date: Tue, 25 Jun 2019 13:58:46 +0100 From: "Dr. David Alan Gilbert" To: Christophe de Dinechin Message-ID: <20190625125846.GJ3226@work-vm> References: <20190625123905.25434-1-dinechin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190625123905.25434-1-dinechin@redhat.com> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 25 Jun 2019 12:58:59 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Christophe de Dinechin (dinechin@redhat.com) wrote: > In hmp_change(), the variable hmp_mon is only used > by code under #ifdef CONFIG_VNC. This results in a build > error when VNC is configured out with the default of > treating warnings as errors: >=20 > monitor/hmp-cmds.c: In function =E2=80=98hmp_change=E2=80=99: > monitor/hmp-cmds.c:1946:17: error: unused variable =E2=80=98hmp_mon=E2=80= =99 [-Werror=3Dunused-variable] > 1946 | MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common= ); > | ^~~~~~~ >=20 > v2: Move variable down as suggested by Philippe Mathieu-Daud=C3=A9 >=20 > Signed-off-by: Christophe de Dinechin Reviewed-by: Dr. David Alan Gilbert > --- > monitor/hmp-cmds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index c283dde0e9..2ae784b9b8 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -1943,7 +1943,6 @@ static void hmp_change_read_arg(void *opaque, con= st char *password, > =20 > void hmp_change(Monitor *mon, const QDict *qdict) > { > - MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); > const char *device =3D qdict_get_str(qdict, "device"); > const char *target =3D qdict_get_str(qdict, "target"); > const char *arg =3D qdict_get_try_str(qdict, "arg"); > @@ -1961,6 +1960,7 @@ void hmp_change(Monitor *mon, const QDict *qdict) > if (strcmp(target, "passwd") =3D=3D 0 || > strcmp(target, "password") =3D=3D 0) { > if (!arg) { > + MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, = common); > monitor_read_password(hmp_mon, hmp_change_read_arg, NU= LL); > return; > } > --=20 > 2.21.0 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK