From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Jiri Denemark <jdenemar@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/6] qmp: Add "alias-of" field to query-cpu-definitions
Date: Tue, 25 Jun 2019 17:15:33 +0100 [thread overview]
Message-ID: <20190625161533.GJ3139@redhat.com> (raw)
In-Reply-To: <20190625050008.12789-4-ehabkost@redhat.com>
On Tue, Jun 25, 2019 at 02:00:05AM -0300, Eduardo Habkost wrote:
> Management software will be expected to resolve CPU model name
> aliases using the new field.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/target.json | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/target.json b/qapi/target.json
> index 1d4d54b600..0197c7962c 100644
> --- a/qapi/target.json
> +++ b/qapi/target.json
> @@ -475,6 +475,12 @@
> # to introspect properties configurable using -cpu or -global.
> # (since 2.9)
> #
> +# @alias-of: Name of CPU model this model is an alias for. The target of the
> +# CPU model alias may change depending on the machine type.
> +# Management software is supposed to translate CPU model aliases
> +# in the VM configuration, because aliases may stop being
> +# migration-safe in the future (since 4.1)
> +#
> # @unavailable-features is a list of QOM property names that
> # represent CPU model attributes that prevent the CPU from running.
> # If the QOM property is read-only, that means there's no known
> @@ -498,7 +504,8 @@
> '*migration-safe': 'bool',
> 'static': 'bool',
> '*unavailable-features': [ 'str' ],
> - 'typename': 'str' },
> + 'typename': 'str',
> + '*alias-of' : 'str' },
> 'if': 'defined(TARGET_PPC) || defined(TARGET_ARM) || defined(TARGET_I386) || defined(TARGET_S390X) || defined(TARGET_MIPS)' }
IIUC, this means that data for a "Haswell" CPU model will now report
"alias-of": "Haswell-NNN" (for some arbitrary NNN which may change
at will in any release).
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-06-25 16:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 5:00 [Qemu-devel] [PATCH 0/6] x86 CPU model versioning Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 1/6] i386: Add x-force-features option for testing Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 2/6] i386: Remove unused host_cpudef variable Eduardo Habkost
2019-06-25 9:04 ` Dr. David Alan Gilbert
2019-06-25 5:00 ` [Qemu-devel] [PATCH 3/6] qmp: Add "alias-of" field to query-cpu-definitions Eduardo Habkost
2019-06-25 16:15 ` Daniel P. Berrangé [this message]
2019-06-25 18:00 ` Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models Eduardo Habkost
2019-06-25 9:32 ` Dr. David Alan Gilbert
2019-06-25 13:40 ` Eduardo Habkost
2019-06-25 14:32 ` Dr. David Alan Gilbert
2019-06-25 14:53 ` Eduardo Habkost
2019-06-25 14:56 ` Dr. David Alan Gilbert
2019-06-25 16:05 ` Eduardo Habkost
2019-06-25 16:26 ` Daniel P. Berrangé
2019-06-25 17:59 ` Eduardo Habkost
2019-06-25 18:08 ` Daniel P. Berrangé
2019-06-25 18:11 ` Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 5/6] docs: Deprecate CPU model runnability guarantees Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 6/6] i386: Add Cascadelake-Server-4.1.1 CPU model Eduardo Habkost
2019-06-25 5:35 ` Tao Xu
2019-06-25 13:11 ` Eduardo Habkost
2019-06-25 5:15 ` [Qemu-devel] [PATCH 0/6] x86 CPU model versioning no-reply
2019-06-25 16:13 ` Daniel P. Berrangé
2019-06-25 18:11 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625161533.GJ3139@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).