qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Sebastien Boeuf" <sebastien.boeuf@intel.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v2 4/4] docs: avoid vhost-user-net specifics in multiqueue section
Date: Wed, 26 Jun 2019 08:48:15 +0100	[thread overview]
Message-ID: <20190626074815.19994-5-stefanha@redhat.com> (raw)
In-Reply-To: <20190626074815.19994-1-stefanha@redhat.com>

The "Multiple queue support" section makes references to vhost-user-net
"queue pairs".  This is confusing for two reasons:
1. This actually applies to all device types, not just vhost-user-net.
2. VHOST_USER_GET_QUEUE_NUM returns the number of virtqueues, not the
   number of queue pairs.

Reword the section so that the vhost-user-net specific part is relegated
to the very end: we acknowledge that vhost-user-net historically
automatically enabled the first queue pair.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 docs/interop/vhost-user.rst | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
index dc0ff9211f..5750668aba 100644
--- a/docs/interop/vhost-user.rst
+++ b/docs/interop/vhost-user.rst
@@ -324,19 +324,20 @@ must support changing some configuration aspects on the fly.
 Multiple queue support
 ----------------------
 
-Multiple queue is treated as a protocol extension, hence the slave has
-to implement protocol features first. The multiple queues feature is
-supported only when the protocol feature ``VHOST_USER_PROTOCOL_F_MQ``
-(bit 0) is set.
+Multiple queue support allows the slave to advertise the maximum number of
+queues.  This is treated as a protocol extension, hence the slave has to
+implement protocol features first. The multiple queues feature is supported
+only when the protocol feature ``VHOST_USER_PROTOCOL_F_MQ`` (bit 0) is set.
 
-The max number of queue pairs the slave supports can be queried with
-message ``VHOST_USER_GET_QUEUE_NUM``. Master should stop when the
-number of requested queues is bigger than that.
+The max number of queues the slave supports can be queried with message
+``VHOST_USER_GET_QUEUE_NUM``. Master should stop when the number of requested
+queues is bigger than that.
 
 As all queues share one connection, the master uses a unique index for each
-queue in the sent message to identify a specified queue. One queue pair
-is enabled initially. More queues are enabled dynamically, by sending
-message ``VHOST_USER_SET_VRING_ENABLE``.
+queue in the sent message to identify a specified queue.
+
+The master enables queues by sending message ``VHOST_USER_SET_VRING_ENABLE``.
+vhost-user-net has historically automatically enabled the first queue pair.
 
 Migration
 ---------
-- 
2.21.0



WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 22/22] docs: avoid vhost-user-net specifics in multiqueue section
Date: Tue, 2 Jul 2019 11:08:59 -0400	[thread overview]
Message-ID: <20190626074815.19994-5-stefanha@redhat.com> (raw)
Message-ID: <20190702150859.vSxqKOTxyoVi3_7xFJ2X_XZVfpICDOikuHp2KCYsu4U@z> (raw)
In-Reply-To: <20190702150606.24851-1-mst@redhat.com>

From: Stefan Hajnoczi <stefanha@redhat.com>

The "Multiple queue support" section makes references to vhost-user-net
"queue pairs".  This is confusing for two reasons:
1. This actually applies to all device types, not just vhost-user-net.
2. VHOST_USER_GET_QUEUE_NUM returns the number of virtqueues, not the
   number of queue pairs.

Reword the section so that the vhost-user-net specific part is relegated
to the very end: we acknowledge that vhost-user-net historically
automatically enabled the first queue pair.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20190626074815.19994-5-stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 docs/interop/vhost-user.rst | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
index dc0ff9211f..5750668aba 100644
--- a/docs/interop/vhost-user.rst
+++ b/docs/interop/vhost-user.rst
@@ -324,19 +324,20 @@ must support changing some configuration aspects on the fly.
 Multiple queue support
 ----------------------
 
-Multiple queue is treated as a protocol extension, hence the slave has
-to implement protocol features first. The multiple queues feature is
-supported only when the protocol feature ``VHOST_USER_PROTOCOL_F_MQ``
-(bit 0) is set.
+Multiple queue support allows the slave to advertise the maximum number of
+queues.  This is treated as a protocol extension, hence the slave has to
+implement protocol features first. The multiple queues feature is supported
+only when the protocol feature ``VHOST_USER_PROTOCOL_F_MQ`` (bit 0) is set.
 
-The max number of queue pairs the slave supports can be queried with
-message ``VHOST_USER_GET_QUEUE_NUM``. Master should stop when the
-number of requested queues is bigger than that.
+The max number of queues the slave supports can be queried with message
+``VHOST_USER_GET_QUEUE_NUM``. Master should stop when the number of requested
+queues is bigger than that.
 
 As all queues share one connection, the master uses a unique index for each
-queue in the sent message to identify a specified queue. One queue pair
-is enabled initially. More queues are enabled dynamically, by sending
-message ``VHOST_USER_SET_VRING_ENABLE``.
+queue in the sent message to identify a specified queue.
+
+The master enables queues by sending message ``VHOST_USER_SET_VRING_ENABLE``.
+vhost-user-net has historically automatically enabled the first queue pair.
 
 Migration
 ---------
-- 
MST



  parent reply	other threads:[~2019-06-26  7:52 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26  7:48 [Qemu-devel] [PATCH v2 0/4] libvhost-user: VHOST_USER_PROTOCOL_F_MQ support Stefan Hajnoczi
2019-06-26  7:48 ` [Qemu-devel] [PATCH v2 1/4] libvhost-user: add vmsg_set_reply_u64() helper Stefan Hajnoczi
2019-07-02 15:08   ` [Qemu-devel] [PULL 19/22] " Michael S. Tsirkin
2019-06-26  7:48 ` [Qemu-devel] [PATCH v2 2/4] libvhost-user: support many virtqueues Stefan Hajnoczi
2019-07-02 15:08   ` [Qemu-devel] [PULL 20/22] " Michael S. Tsirkin
2019-06-26  7:48 ` [Qemu-devel] [PATCH v2 3/4] libvhost-user: implement VHOST_USER_PROTOCOL_F_MQ Stefan Hajnoczi
2019-07-02 15:08   ` [Qemu-devel] [PULL 21/22] " Michael S. Tsirkin
2019-06-26  7:48 ` Stefan Hajnoczi [this message]
2019-07-02 15:08   ` [Qemu-devel] [PULL 22/22] docs: avoid vhost-user-net specifics in multiqueue section Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2019-07-02 15:06 [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups Michael S. Tsirkin
2019-06-25 23:23 ` [Qemu-devel] [PATCH] virtio-pci: fix missing device properties Marc-André Lureau
2019-06-26  1:55   ` Eduardo Habkost
2019-06-26  9:48     ` Marc-André Lureau
2019-06-26 12:39       ` Eduardo Habkost
2019-07-02 15:07   ` [Qemu-devel] [PULL 12/22] " Michael S. Tsirkin
2019-06-28 20:02 ` [Qemu-devel] [PATCH] pc: Move compat_apic_id_mode variable to PCMachineClass Eduardo Habkost
2019-06-29 10:46   ` Philippe Mathieu-Daudé
2019-06-30 21:30   ` Michael S. Tsirkin
2019-07-02 15:08   ` [Qemu-devel] [PULL 18/22] " Michael S. Tsirkin
2019-07-02 15:06 ` [Qemu-devel] [PULL 01/22] pcie: don't skip multi-mask events Michael S. Tsirkin
2019-07-02 15:06 ` [Qemu-devel] [PULL 02/22] pcie: check that slt ctrl changed before deleting Michael S. Tsirkin
2019-07-11 12:31   ` Peter Maydell
2019-07-02 15:06 ` [Qemu-devel] [PULL 03/22] pcie: work around for racy guest init Michael S. Tsirkin
2019-07-02 15:06 ` [Qemu-devel] [PULL 04/22] pcie: minor cleanups for slot control/status Michael S. Tsirkin
2019-07-02 15:56 ` [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups Peter Maydell
2019-07-02 17:00   ` Michael S. Tsirkin
2019-07-02 17:20     ` Peter Maydell
2019-07-02 18:22       ` Michael S. Tsirkin
2019-07-02 18:27         ` Peter Maydell
2019-07-02 19:00           ` Michael S. Tsirkin
2019-07-26 12:39           ` Peter Maydell
2019-07-26 13:43             ` Michael S. Tsirkin
2019-07-04  9:25 ` Peter Maydell
2019-07-04 11:03   ` Pankaj Gupta
2019-07-04 21:24     ` Michael S. Tsirkin
2019-07-05  9:37       ` Pankaj Gupta
2019-07-04 21:29   ` Michael S. Tsirkin
2019-07-05  9:47     ` Peter Maydell
2019-06-26  2:31 [Qemu-devel] [PATCH v4 0/5] virtio: fix some issues of "started" and "start_on_kick" flag elohimes
2019-06-26  2:31 ` [Qemu-devel] [PATCH v4 1/5] virtio: add "use-started" property elohimes
2019-06-26 10:17   ` Greg Kurz
2019-06-27  2:20     ` Yongji Xie
2019-07-02 15:07   ` [Qemu-devel] [PULL 13/22] " Michael S. Tsirkin
2019-06-26  2:31 ` [Qemu-devel] [PATCH v4 2/5] virtio: Set "start_on_kick" for legacy devices elohimes
2019-07-02 15:07   ` [Qemu-devel] [PULL 14/22] " Michael S. Tsirkin
2019-06-26  2:31 ` [Qemu-devel] [PATCH v4 3/5] virtio: Set "start_on_kick" on virtio_set_features() elohimes
2019-07-02 15:08   ` [Qemu-devel] [PULL 15/22] " Michael S. Tsirkin
2019-06-26  2:31 ` [Qemu-devel] [PATCH v4 4/5] virtio: Make sure we get correct state of device on handle_aio_output() elohimes
2019-07-02 15:08   ` [Qemu-devel] [PULL 16/22] " Michael S. Tsirkin
2019-06-26  2:31 ` [Qemu-devel] [PATCH v4 5/5] virtio: Don't change "started" flag on virtio_vmstate_change() elohimes
2019-07-02 15:08   ` [Qemu-devel] [PULL 17/22] " Michael S. Tsirkin
2019-06-26 10:43 ` [Qemu-devel] [PATCH v4 0/5] virtio: fix some issues of "started" and "start_on_kick" flag Laurent Vivier
2019-06-27  2:19   ` Yongji Xie
2019-06-19  9:49 [Qemu-devel] [PATCH v2 0/7] Qemu virtio pmem device Pankaj Gupta
2019-06-19  9:49 ` [Qemu-devel] [PATCH v2 1/7] virtio-pmem: add virtio device Pankaj Gupta
2019-07-02 11:46   ` Cornelia Huck
2019-07-02 15:07   ` [Qemu-devel] [PULL 05/22] " Michael S. Tsirkin
2019-07-11 12:57   ` Peter Maydell
2019-07-11 14:05     ` Pankaj Gupta
2019-06-19  9:49 ` [Qemu-devel] [PATCH v2 2/7] virtio-pci: Allow to specify additional interfaces for the base type Pankaj Gupta
2019-07-02 15:07   ` [Qemu-devel] [PULL 06/22] " Michael S. Tsirkin
2019-06-19  9:49 ` [Qemu-devel] [PATCH v2 3/7] virtio-pmem: sync linux headers Pankaj Gupta
2019-07-02 11:50   ` Cornelia Huck
2019-07-02 11:59     ` Pankaj Gupta
2019-07-02 16:58       ` Michael S. Tsirkin
2019-07-02 17:09         ` Pankaj Gupta
2019-07-02 17:11           ` Michael S. Tsirkin
2019-07-02 17:21             ` Pankaj Gupta
2019-07-02 15:10     ` Michael S. Tsirkin
2019-07-02 15:07   ` [Qemu-devel] [PULL 07/22] " Michael S. Tsirkin
2019-06-19  9:49 ` [Qemu-devel] [PATCH v2 4/7] virtio-pci: Proxy for virtio-pmem Pankaj Gupta
2019-07-02 11:55   ` Cornelia Huck
2019-07-02 12:00     ` Pankaj Gupta
2019-07-02 17:09     ` Michael S. Tsirkin
2019-07-02 17:14       ` Pankaj Gupta
2019-07-02 15:07   ` [Qemu-devel] [PULL 08/22] " Michael S. Tsirkin
2019-07-11 12:59   ` Peter Maydell
2019-07-11 13:27     ` Pankaj Gupta
2019-06-19  9:49 ` [Qemu-devel] [PATCH v2 5/7] hmp: Handle virtio-pmem when printing memory device infos Pankaj Gupta
2019-07-02  8:50   ` Wei Yang
2019-07-02 10:17     ` Pankaj Gupta
2019-07-02 15:07   ` [Qemu-devel] [PULL 09/22] " Michael S. Tsirkin
2019-06-19  9:49 ` [Qemu-devel] [PATCH v2 6/7] numa: Handle virtio-pmem in NUMA stats Pankaj Gupta
2019-07-02 15:07   ` [Qemu-devel] [PULL 10/22] " Michael S. Tsirkin
2019-06-19  9:49 ` [Qemu-devel] [PATCH v2 7/7] pc: Support for virtio-pmem-pci Pankaj Gupta
2019-07-02 15:07   ` [Qemu-devel] [PULL 11/22] " Michael S. Tsirkin
2019-07-01  3:53 ` [Qemu-devel] [PATCH v2 0/7] Qemu virtio pmem device Pankaj Gupta
2019-07-02  8:49 ` Wei Yang
2019-07-02 10:07   ` Pankaj Gupta
2019-07-03  0:58     ` Wei Yang
2019-07-03  1:31       ` Pankaj Gupta
2019-07-03  1:57         ` Wei Yang
2019-07-03  2:31           ` Pankaj Gupta
2019-07-03  2:42             ` Wei Yang
2019-07-03  3:21               ` Pankaj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626074815.19994-5-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sebastien.boeuf@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).