From: Justin Hibbits <chmeeedalf@gmail.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-trivial@nongnu.org, "Emilio G. Cota" <cota@braap.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)
Date: Wed, 26 Jun 2019 11:37:42 -0500 [thread overview]
Message-ID: <20190626113742.6bcd8a26@titan.knownspace> (raw)
In-Reply-To: <92053c9c-e7bf-76cb-9399-987f4ab31bfb@vivier.eu>
On Wed, 26 Jun 2019 18:16:36 +0200
Laurent Vivier <laurent@vivier.eu> wrote:
> Le 26/06/2019 à 18:14, Laurent Vivier a écrit :
> > Le 07/06/2019 à 20:56, Justin Hibbits a écrit :
> >> The attached very trivial patch fixes a startup bug that prevents
> >> at least Qemu 3.1 and later from working on FreeBSD/powerpc64.
> >>
> >> - Justin
> >>
> >
> > Please don't send a patch in attachment but inlined in the message
> > (you may use "git send-email" for that).
> >
> > This patch fixes "util: add cacheinfo" that has changed the type
> > from unsigned to long.
> >
> > You can add the following line in the commit message:
> >
> > Fixes: b255b2c8a548 ("util: add cacheinfo")
> >
> > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> >
>
> CC: author of b255b2c8a548 ("util: add cacheinfo")
>
> Thanks,
> Laurent
Hi Laurent,
Sorry. I had never used git send-email before, so wasn't comfortable
with it. I just updated the commit message with your feedback and used
git send-email to submit the patch. I hope everything went well.
Thanks for your feedback.
- Justin
next prev parent reply other threads:[~2019-06-26 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 18:56 [Qemu-devel] Fix cacheline size retrieval on FreeBSD/PowerPC(64) Justin Hibbits
2019-06-26 16:14 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-06-26 16:16 ` Laurent Vivier
2019-06-26 16:37 ` Justin Hibbits [this message]
2019-06-26 16:47 ` Laurent Vivier
2019-06-26 18:04 ` Justin Hibbits
2019-06-27 0:02 ` Justin Hibbits
2019-06-27 0:08 ` Laurent Vivier
2019-06-27 0:15 ` Justin Hibbits
2019-07-01 8:54 ` Laurent Vivier
2019-07-01 13:02 ` Justin Hibbits
2019-07-01 13:17 ` Laurent Vivier
2019-07-02 22:11 ` Justin Hibbits
2019-07-01 14:08 ` Christophe de Dinechin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626113742.6bcd8a26@titan.knownspace \
--to=chmeeedalf@gmail.com \
--cc=cota@braap.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).