From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: Wei Yang <richardw.yang@linux.intel.com>,
dgilbert@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH 1/3] migration/postcopy: the valid condition is one less then end
Date: Thu, 27 Jun 2019 10:08:20 +0800 [thread overview]
Message-ID: <20190627020822.15485-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190627020822.15485-1-richardw.yang@linux.intel.com>
If one equals end, it means we have gone through the whole bitmap.
Use a more restrict check to skip a unnecessary condition.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 908517fc2b..b78169e811 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2777,7 +2777,7 @@ static int postcopy_send_discard_bm_ram(MigrationState *ms,
for (current = 0; current < end; ) {
unsigned long one = find_next_bit(unsentmap, end, current);
- if (one <= end) {
+ if (one < end) {
unsigned long zero = find_next_zero_bit(unsentmap, end, one + 1);
unsigned long discard_length;
--
2.19.1
next prev parent reply other threads:[~2019-06-27 2:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 2:08 [Qemu-devel] [PATCH 0/3] migration/postcopy: cleanup function postcopy_send_discard_bm_ram Wei Yang
2019-06-27 2:08 ` Wei Yang [this message]
2019-06-28 15:09 ` [Qemu-devel] [PATCH 1/3] migration/postcopy: the valid condition is one less then end Dr. David Alan Gilbert
2019-06-28 23:04 ` Wei Yang
2019-06-27 2:08 ` [Qemu-devel] [PATCH 2/3] migration/postcopy: break the loop when there is no more page to discard Wei Yang
2019-06-28 15:15 ` Dr. David Alan Gilbert
2019-06-27 2:08 ` [Qemu-devel] [PATCH 3/3] migration/postcopy: discard_length must not be 0 Wei Yang
2019-06-28 15:17 ` Dr. David Alan Gilbert
2019-08-07 17:16 ` [Qemu-devel] [PATCH 0/3] migration/postcopy: cleanup function postcopy_send_discard_bm_ram Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627020822.15485-2-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).