From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stephen Checkoway <stephen.checkoway@oberlin.edu>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-block@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"John Snow" <jsnow@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Michael Walle" <michael@walle.cc>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"Antony Pavlov" <antonynpavlov@gmail.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH v5 22/28] hw/block/pflash_cfi02: Fix reset command not ignored during erase
Date: Thu, 27 Jun 2019 22:27:13 +0200 [thread overview]
Message-ID: <20190627202719.17739-23-philmd@redhat.com> (raw)
In-Reply-To: <20190627202719.17739-1-philmd@redhat.com>
From: Stephen Checkoway <stephen.checkoway@oberlin.edu>
When the flash device is performing a chip erase, all commands are
ignored. When it is performing a sector erase, only the erase suspend
command is valid, which is currently not supported.
In particular, the reset command should not cause the device to reset to
read array mode while programming is on going.
Signed-off-by: Stephen Checkoway <stephen.checkoway@oberlin.edu>
Message-Id: <20190426162624.55977-8-stephen.checkoway@oberlin.edu>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/block/pflash_cfi02.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index 13f76fa71d..39daa95833 100644
--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -311,7 +311,8 @@ static void pflash_write(void *opaque, hwaddr offset, uint64_t value,
trace_pflash_io_write(offset, width, width << 1, value, pfl->wcycle);
cmd = value;
if (pfl->cmd != 0xA0) {
- if (cmd == 0xF0) {
+ /* Reset does nothing during chip erase and sector erase. */
+ if (cmd == 0xF0 && pfl->cmd != 0x10 && pfl->cmd != 0x30) {
if (pfl->wcycle == WCYCLE_AUTOSELECT_CFI) {
/* Return to autoselect mode. */
pfl->wcycle = 3;
--
2.20.1
next prev parent reply other threads:[~2019-06-27 21:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 20:26 [Qemu-devel] [PATCH v5 00/28] block/pflash_cfi02: Implement missing AMD pflash functionality Philippe Mathieu-Daudé
2019-06-27 20:26 ` [Qemu-devel] [PATCH v5 01/28] tests/pflash-cfi02: Add test for supported CFI commands Philippe Mathieu-Daudé
2019-06-27 20:26 ` [Qemu-devel] [PATCH v5 02/28] hw/block/pflash: Simplify trace_pflash_io_read/write() Philippe Mathieu-Daudé
2019-06-27 21:49 ` Stephen Checkoway
2019-06-28 15:53 ` Alistair Francis
2019-06-28 15:52 ` Alistair Francis
2019-06-27 20:26 ` [Qemu-devel] [PATCH v5 03/28] hw/block/pflash: Simplify trace_pflash_data_read/write() Philippe Mathieu-Daudé
2019-06-28 15:54 ` Alistair Francis
2019-06-27 20:26 ` [Qemu-devel] [PATCH v5 04/28] hw/block/pflash_cfi02: Fix debug format string Philippe Mathieu-Daudé
2019-06-28 15:55 ` Alistair Francis
2019-06-27 20:26 ` [Qemu-devel] [PATCH v5 05/28] hw/block/pflash_cfi02: Add an enum to define the write cycles Philippe Mathieu-Daudé
2019-06-28 15:56 ` Alistair Francis
2019-06-27 20:26 ` [Qemu-devel] [PATCH v5 06/28] hw/block/pflash_cfi02: Add helpers to manipulate the status bits Philippe Mathieu-Daudé
2019-06-28 16:00 ` Alistair Francis
2019-06-27 20:26 ` [Qemu-devel] [PATCH v5 07/28] hw/block/pflash_cfi02: Simplify a statement using fall through Philippe Mathieu-Daudé
2019-06-28 16:01 ` Alistair Francis
2019-06-27 20:26 ` [Qemu-devel] [PATCH v5 08/28] hw/block/pflash_cfi02: Use the ldst API in pflash_write() Philippe Mathieu-Daudé
2019-06-28 16:03 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 09/28] hw/block/pflash_cfi02: Use the ldst API in pflash_read() Philippe Mathieu-Daudé
2019-06-28 16:03 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 10/28] hw/block/pflash_cfi02: Extract the pflash_data_read() function Philippe Mathieu-Daudé
2019-06-28 16:17 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 11/28] hw/block/pflash_cfi02: Unify the MemoryRegionOps Philippe Mathieu-Daudé
2019-06-28 16:25 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 12/28] hw/block/pflash_cfi02: Fix command address comparison Philippe Mathieu-Daudé
2019-06-28 16:28 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 13/28] tests/pflash-cfi02: Refactor to support testing multiple configurations Philippe Mathieu-Daudé
2019-06-28 16:41 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 14/28] hw/block/pflash_cfi02: Remove pointless local variable Philippe Mathieu-Daudé
2019-06-28 16:32 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 15/28] hw/block/pflash_cfi02: Document the current CFI values Philippe Mathieu-Daudé
2019-06-28 16:33 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 16/28] hw/block/pflash_cfi02: Hold the PRI table offset in a variable Philippe Mathieu-Daudé
2019-06-28 16:34 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 17/28] hw/block/pflash_cfi02: Document 'Page Mode' operations are not supported Philippe Mathieu-Daudé
2019-06-28 16:35 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 18/28] hw/block/pflash_cfi02: Implement nonuniform sector sizes Philippe Mathieu-Daudé
2019-06-28 17:28 ` Philippe Mathieu-Daudé
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 19/28] hw/block/pflash_cfi02: Extract pflash_regions_count() Philippe Mathieu-Daudé
2019-06-28 16:43 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 20/28] hw/block/pflash_cfi02: Split if() condition Philippe Mathieu-Daudé
2019-06-28 23:06 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 21/28] hw/block/pflash_cfi02: Fix CFI in autoselect mode Philippe Mathieu-Daudé
2019-06-28 23:08 ` Alistair Francis
2019-06-27 20:27 ` Philippe Mathieu-Daudé [this message]
2019-06-28 23:11 ` [Qemu-devel] [PATCH v5 22/28] hw/block/pflash_cfi02: Fix reset command not ignored during erase Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 23/28] hw/block/pflash_cfi02: Implement multi-sector erase Philippe Mathieu-Daudé
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 24/28] hw/block/pflash_cfi02: Implement erase suspend/resume Philippe Mathieu-Daudé
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 25/28] hw/block/pflash_cfi02: Use chip erase time specified in the CFI table Philippe Mathieu-Daudé
2019-06-28 23:12 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 26/28] hw/block/pflash_cfi02: Reduce single byte/word write delay Philippe Mathieu-Daudé
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 27/28] hw/block/pflash_cfi02: Document commands Philippe Mathieu-Daudé
2019-06-28 23:13 ` Alistair Francis
2019-06-27 20:27 ` [Qemu-devel] [PATCH v5 28/28] hw/block/pflash_cfi02: Reduce I/O accesses to 16-bit Philippe Mathieu-Daudé
2019-06-28 23:13 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627202719.17739-23-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alistair@alistair23.me \
--cc=antonynpavlov@gmail.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=jan.kiszka@web.de \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=michael@walle.cc \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=stephen.checkoway@oberlin.edu \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).