From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 23/29] i386: Fix signedness of hyperv_spinlock_attempts
Date: Thu, 27 Jun 2019 22:56:00 -0300 [thread overview]
Message-ID: <20190628015606.32107-24-ehabkost@redhat.com> (raw)
In-Reply-To: <20190628015606.32107-1-ehabkost@redhat.com>
The current default value for hv-spinlocks is 0xFFFFFFFF (meaning
"never retry"). However, the value is stored as a signed
integer, making the getter of the hv-spinlocks QOM property
return -1 instead of 0xFFFFFFFF.
Fix this by changing the type of X86CPU::hyperv_spinlock_attempts
to uint32_t. This has no visible effect to guest operating
systems, affecting just the behavior of the QOM getter.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20190615200505.31348-1-ehabkost@redhat.com>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Roman Kagan <rkagan@virtuozzo.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/i386/cpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index 4d2ae2384e..ff26351538 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -1408,7 +1408,7 @@ struct X86CPU {
CPUNegativeOffsetState neg;
CPUX86State env;
- int hyperv_spinlock_attempts;
+ uint32_t hyperv_spinlock_attempts;
char *hyperv_vendor_id;
bool hyperv_synic_kvm_only;
uint64_t hyperv_features;
--
2.18.0.rc1.1.g3f1ff2140
next prev parent reply other threads:[~2019-06-28 2:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 1:55 [Qemu-devel] [PULL 00/29] Machine next patches Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 01/29] hw/boards: Add struct CpuTopology to MachineState Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 02/29] machine: Refactor smp-related call chains to pass MachineState Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 03/29] general: Replace global smp variables with smp machine properties Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 04/29] hw/ppc: Replace global smp variables with machine smp properties Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 05/29] hw/riscv: " Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 06/29] hw/s390x: " Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 07/29] hw/i386: " Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 08/29] hw/arm: " Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 09/29] hw: Replace global smp variables with MachineState for all remaining archs Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 10/29] vl.c: Replace smp global variables with smp machine properties Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 11/29] i386: Add die-level cpu topology to x86CPU on PCMachine Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 12/29] hw/i386: Adjust nr_dies with configured smp_dies for PCMachine Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 13/29] i386/cpu: Consolidate die-id validity in smp context Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 14/29] i386: Update new x86_apicid parsing rules with die_offset support Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 15/29] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size() Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 16/29] machine: show if CLI option '-numa node, mem' is supported in QAPI schema Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 17/29] numa: deprecate 'mem' parameter of '-numa node' option Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 18/29] numa: deprecate implict memory distribution between nodes Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 19/29] hppa: Delete unused hppa_cpu_list() function Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 20/29] target/i386: fix feature check in hyperv-stub.c Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 21/29] deprecate -mem-path fallback to anonymous RAM Eduardo Habkost
2019-06-28 1:55 ` [Qemu-devel] [PULL 22/29] i386: Don't print warning if phys-bits was set automatically Eduardo Habkost
2019-06-28 1:56 ` Eduardo Habkost [this message]
2019-06-28 1:56 ` [Qemu-devel] [PULL 24/29] i386: make 'hv-spinlocks' a regular uint32 property Eduardo Habkost
2019-06-28 1:56 ` [Qemu-devel] [PULL 25/29] x86/cpu: use FeatureWordArray to define filtered_features Eduardo Habkost
2019-06-28 1:56 ` [Qemu-devel] [PULL 26/29] i386: Remove unused host_cpudef variable Eduardo Habkost
2019-06-28 1:56 ` [Qemu-devel] [PULL 27/29] target/i386: Add CPUID.1F generation support for multi-dies PCMachine Eduardo Habkost
2019-06-28 1:56 ` [Qemu-devel] [PULL 28/29] machine: Refactor smp_parse() in vl.c as MachineClass::smp_parse() Eduardo Habkost
2019-06-28 1:56 ` [Qemu-devel] [PULL 29/29] vl.c: Add -smp, dies=* command line support and update doc Eduardo Habkost
2019-06-28 2:49 ` [Qemu-devel] [PULL 00/29] Machine next patches no-reply
2019-06-28 18:49 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628015606.32107-24-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).