From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08FFC4321A for ; Fri, 28 Jun 2019 09:27:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8884320665 for ; Fri, 28 Jun 2019 09:27:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8884320665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgn9q-0006DN-Qm for qemu-devel@archiver.kernel.org; Fri, 28 Jun 2019 05:27:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45826) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgn7W-0004YM-A8 for qemu-devel@nongnu.org; Fri, 28 Jun 2019 05:24:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgn7V-0004ef-7G for qemu-devel@nongnu.org; Fri, 28 Jun 2019 05:24:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59262) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgn7S-0004cY-Pw; Fri, 28 Jun 2019 05:24:34 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14A13307E040; Fri, 28 Jun 2019 09:24:34 +0000 (UTC) Received: from dhcp-200-226.str.redhat.com (dhcp-200-226.str.redhat.com [10.33.200.226]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3CCB60920; Fri, 28 Jun 2019 09:24:30 +0000 (UTC) Date: Fri, 28 Jun 2019 11:24:29 +0200 From: Kevin Wolf To: John Snow Message-ID: <20190628092429.GB5179@dhcp-200-226.str.redhat.com> References: <20190626215301.30733-1-jsnow@redhat.com> <20190627083453.GC5618@localhost.localdomain> <5a374041-10a2-5ae3-6db1-966c7589b1cd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a374041-10a2-5ae3-6db1-966c7589b1cd@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 28 Jun 2019 09:24:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qemu-Trivial , radmehrsaeed7@gmail.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 27.06.2019 um 19:17 hat John Snow geschrieben: > > > On 6/27/19 4:34 AM, Kevin Wolf wrote: > > Am 26.06.2019 um 23:53 hat John Snow geschrieben: > >> Reported-by: radmehrsaeed7@gmail.com > >> Fixes: https://bugs.launchpad.net/bugs/1832914 > >> Signed-off-by: John Snow > >> --- > >> block/qcow.c | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > >> > >> diff --git a/block/qcow.c b/block/qcow.c > >> index 6dee5bb792..a9cb6ae0bd 100644 > >> --- a/block/qcow.c > >> +++ b/block/qcow.c > >> @@ -156,7 +156,12 @@ static int qcow_open(BlockDriverState *bs, QDict *options, int flags, > >> goto fail; > >> } > >> if (header.version != QCOW_VERSION) { > >> - error_setg(errp, "Unsupported qcow version %" PRIu32, header.version); > >> + error_setg(errp, "qcow (v%d) does not support qcow version %" PRIu32, > >> + QCOW_VERSION, header.version); > >> + if (header.version == 2 || header.version == 3) { > >> + error_append_hint(errp, "Try the 'qcow2' driver instead."); > > > > I think we want a \n at the end here. > > > > D'oh. > > > Kevin > > Can a maintainer pretty-please make the edit? A maintainer did that now. (read: thanks, applied) Kevin