From: "Daniel P. Berrangé" <berrange@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: Riccardo Schirone <rschiron@redhat.com>,
Li Qiang <liq3ea@gmail.com>,
Qemu Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qemu-bridge-helper: restrict bridge name to IFNAMSIZ
Date: Fri, 28 Jun 2019 13:18:46 +0100 [thread overview]
Message-ID: <20190628121846.GE23344@redhat.com> (raw)
In-Reply-To: <nycvar.YSQ.7.76.1906281725370.18180@xnncv>
On Fri, Jun 28, 2019 at 05:32:50PM +0530, P J P wrote:
> +-- On Fri, 28 Jun 2019, Daniel P. Berrangé wrote --+
> | Ok, so we should explicitly report an error if the user supplied bridge name
> | is too long, not silently truncate it.
> |
> | We should also report an error if config file has too long a bridge name.
>
> Okay, ie. report error and exit?
Yes, exactly.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-06-28 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 9:49 [Qemu-devel] [PATCH] qemu-bridge-helper: restrict bridge name to IFNAMSIZ P J P
2019-06-28 11:04 ` Daniel P. Berrangé
2019-06-28 11:21 ` P J P
2019-06-28 11:32 ` Daniel P. Berrangé
2019-06-28 12:02 ` P J P
2019-06-28 12:18 ` Daniel P. Berrangé [this message]
2019-06-28 11:42 ` Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628121846.GE23344@redhat.com \
--to=berrange@redhat.com \
--cc=liq3ea@gmail.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rschiron@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).