From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D0E6C5B57E for ; Sun, 30 Jun 2019 17:41:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5C9E2054F for ; Sun, 30 Jun 2019 17:41:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5C9E2054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhdpa-0006aJ-KH for qemu-devel@archiver.kernel.org; Sun, 30 Jun 2019 13:41:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59072) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhdny-0005QN-6X for qemu-devel@nongnu.org; Sun, 30 Jun 2019 13:40:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhdnv-0004su-MJ for qemu-devel@nongnu.org; Sun, 30 Jun 2019 13:39:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57350) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hhdnv-0004es-61 for qemu-devel@nongnu.org; Sun, 30 Jun 2019 13:39:55 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB2744E92A for ; Sun, 30 Jun 2019 17:39:41 +0000 (UTC) Received: from localhost.localdomain (ovpn-120-238.rdu2.redhat.com [10.10.120.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A79181001B14; Sun, 30 Jun 2019 17:39:34 +0000 (UTC) Date: Sun, 30 Jun 2019 13:39:33 -0400 From: Cleber Rosa To: Eduardo Habkost Message-ID: <20190630173933.GB2820@localhost.localdomain> References: <20190628150217.32659-1-wainersm@redhat.com> <20190628150217.32659-4-wainersm@redhat.com> <20190628201846.GK1862@habkost.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190628201846.GK1862@habkost.net> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 30 Jun 2019 17:39:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 3/3] tests/acceptance: Add boot linux with kvm test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 28, 2019 at 05:18:46PM -0300, Eduardo Habkost wrote: > On Fri, Jun 28, 2019 at 11:02:17AM -0400, Wainer dos Santos Moschetta wrote: > > Until now the suite of acceptance tests doesn't exercise > > QEMU with kvm enabled. So this introduces a simple test > > that boots the Linux kernel and checks it boots on the > > accelerator correctly. > > > > Signed-off-by: Wainer dos Santos Moschetta > > Why not just change the existing test_x86_64_pc() test case to > use KVM by default? We can use "accel=kvm:tcg" to allow it to > fall back to TCG if KVM is not available. > > -- > Eduardo I though of something similar, but not exactly the same. An example can be seen here: https://travis-ci.org/clebergnu/qemu/jobs/551437429#L3350 IMO, it's a good practice to be able to briefly describe what a test does, given its name. It's also very important for the test to attempt to exercise the same behavior across executions. I'm saying that because I don't think we should fallback to TCG if KVM is not available, but instead, have two different tests that do each a simpler and more predictable set of checks. This would make it simpler to find KVM issues when a given test fails but the TCG continues to pass. The tags (and other mechanisms) can be used to select the tests that a given job should run though. Regards! - Cleber.