From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 020BAC0650E for ; Mon, 1 Jul 2019 09:26:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD7B220B7C for ; Mon, 1 Jul 2019 09:26:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD7B220B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhsaG-00014F-49 for qemu-devel@archiver.kernel.org; Mon, 01 Jul 2019 05:26:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48373) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhsZ1-0008Gt-CV for qemu-devel@nongnu.org; Mon, 01 Jul 2019 05:25:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhsZ0-0003XV-Eg for qemu-devel@nongnu.org; Mon, 01 Jul 2019 05:25:31 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:34323) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhsZ0-0003WU-7U for qemu-devel@nongnu.org; Mon, 01 Jul 2019 05:25:30 -0400 Received: by mail-qt1-f193.google.com with SMTP id m29so13900327qtu.1 for ; Mon, 01 Jul 2019 02:25:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ACWMxD4prjF3RaD3oYlQ3n0u3XdGgrroQgSRyA83/v8=; b=WW6XAS+NRV1idToaoFXv5YJ/JFsNX8NkntnPpPxH/Rl9615kGeVIhUFMbEfs8g/nF+ zKj1AyHpXuOgwG3H7XfybOA5mwhrRQ7w/h/3c93zB7p7AGqrM1EuynCU24Oak27OMvXr weIiFyzj2062/VluODIU3bAbEBVlnGk1BUXCKlLQr024vAPbNkrN1zYYVlURM8NNg9ge Ku61omMaCHJDhV0w2APoQ/4tRT3hOQcEE2EddAfhJmTHOUKcRkeh6Ch7bG4QDoIZ//jG SklRXaparZ5mjWVjyvVKEopxeKeiye/cxofjzfT64S5mfOPD1nMw2tqmvGafjpDbknYj 1F3A== X-Gm-Message-State: APjAAAW++nV6rZmQSZRHhi4vvLpV6LJ0b6JMwnKYo0zBR9889aLDkk/n NsRfozDgS+b5uldu3J5HVjXccQ== X-Google-Smtp-Source: APXvYqxu6NwtGhOCqzl8v5Gzx1RUcJ2phSKNVXLdcmBNL8vOL99tGZ10WFp3lT+UUZs2DJc4voFTRQ== X-Received: by 2002:ac8:124c:: with SMTP id g12mr18626119qtj.57.1561973129598; Mon, 01 Jul 2019 02:25:29 -0700 (PDT) Received: from redhat.com ([37.26.146.159]) by smtp.gmail.com with ESMTPSA id u1sm5212054qth.21.2019.07.01.02.25.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Jul 2019 02:25:28 -0700 (PDT) Date: Mon, 1 Jul 2019 05:25:19 -0400 From: "Michael S. Tsirkin" To: Sergio Lopez Message-ID: <20190701052511-mutt-send-email-mst@kernel.org> References: <20190628115349.60293-1-slp@redhat.com> <20190628115349.60293-2-slp@redhat.com> <20190628200328.GI1862@habkost.net> <87lfxlwfko.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lfxlwfko.fsf@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.193 Subject: Re: [Qemu-devel] [PATCH 1/4] hw/i386: Factorize CPU routine X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, Eduardo Habkost , rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 28, 2019 at 11:44:07PM +0200, Sergio Lopez wrote: > > Eduardo Habkost writes: > > > On Fri, Jun 28, 2019 at 01:53:46PM +0200, Sergio Lopez wrote: > > [...] > >> /* Enables contiguous-apic-ID mode, for compatibility */ > >> -static bool compat_apic_id_mode; > >> +bool compat_apic_id_mode; > > > > We can get rid of this global variable, see the patch I have just > > sent: > > > > [PATCH] pc: Move compat_apic_id_mode variable to PCMachineClass > > Nice. I'll adapt the v2 of the patchset to assume this has been > committed. > > Thanks! > Sergio. or include it for completeness.