From: P J P <ppandit@redhat.com>
To: Qemu Developers <qemu-devel@nongnu.org>
Cc: "Riccardo Schirone" <rschiron@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Jason Wang" <jasowang@redhat.com>, "Li Qiang" <liq3ea@gmail.com>,
"Prasad J Pandit" <pjp@fedoraproject.org>
Subject: [Qemu-devel] [PATCH v2 0/3] restrict bridge interface name to IFNAMSIZ
Date: Mon, 1 Jul 2019 14:39:01 +0530 [thread overview]
Message-ID: <20190701090904.31312-1-ppandit@redhat.com> (raw)
From: Prasad J Pandit <pjp@fedoraproject.org>
Hello,
Linux net_deivce defines network interface name to be of IFNAMSIZE(=16)
bytes, including the terminating null('\0') byte.
Qemu tap deivce, while invoking 'qemu-bridge-helper' tool to set up the
network bridge interface, supplies bridge name of 16 characters, thus
allowing to create an ACL bypass scenario.
This patch series attempts to fix it.
Thank you.
---
Prasad J Pandit (3):
qemu-bridge-helper: restrict interface name to IFNAMSIZ
qemu-bridge-helper: move repeating code in parse_acl_file
net: tap: restrict bridge name to IFNAMSIZ
net/tap.c | 2 +-
qemu-bridge-helper.c | 23 ++++++++++++++++-------
2 files changed, 17 insertions(+), 8 deletions(-)
--
2.21.0
next reply other threads:[~2019-07-01 9:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 9:09 P J P [this message]
2019-07-01 9:09 ` [Qemu-devel] [PATCH v2 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ P J P
2019-07-01 9:43 ` Daniel P. Berrangé
2019-07-01 9:58 ` P J P
2019-07-01 9:09 ` [Qemu-devel] [PATCH v2 2/3] qemu-bridge-helper: move repeating code in parse_acl_file P J P
2019-07-01 9:44 ` Daniel P. Berrangé
2019-07-01 9:09 ` [Qemu-devel] [PATCH v2 3/3] net: tap: restrict bridge name to IFNAMSIZ P J P
2019-07-01 9:37 ` Daniel P. Berrangé
2019-07-01 9:57 ` P J P
2019-07-01 9:21 ` [Qemu-devel] [PATCH v2 0/3] restrict bridge interface " no-reply
2019-07-01 10:08 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701090904.31312-1-ppandit@redhat.com \
--to=ppandit@redhat.com \
--cc=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=liq3ea@gmail.com \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
--cc=rschiron@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).