From: "Daniel P. Berrangé" <berrange@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: Riccardo Schirone <rschiron@redhat.com>,
Jason Wang <jasowang@redhat.com>, Li Qiang <liq3ea@gmail.com>,
Qemu Developers <qemu-devel@nongnu.org>,
Prasad J Pandit <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] qemu-bridge-helper: move repeating code in parse_acl_file
Date: Mon, 1 Jul 2019 10:44:20 +0100 [thread overview]
Message-ID: <20190701094420.GG3573@redhat.com> (raw)
In-Reply-To: <20190701090904.31312-3-ppandit@redhat.com>
On Mon, Jul 01, 2019 at 02:39:03PM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Move repeating error handling sequence in parse_acl_file routine
> to an 'err' label.
>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> qemu-bridge-helper.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-07-01 9:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 9:09 [Qemu-devel] [PATCH v2 0/3] restrict bridge interface name to IFNAMSIZ P J P
2019-07-01 9:09 ` [Qemu-devel] [PATCH v2 1/3] qemu-bridge-helper: restrict " P J P
2019-07-01 9:43 ` Daniel P. Berrangé
2019-07-01 9:58 ` P J P
2019-07-01 9:09 ` [Qemu-devel] [PATCH v2 2/3] qemu-bridge-helper: move repeating code in parse_acl_file P J P
2019-07-01 9:44 ` Daniel P. Berrangé [this message]
2019-07-01 9:09 ` [Qemu-devel] [PATCH v2 3/3] net: tap: restrict bridge name to IFNAMSIZ P J P
2019-07-01 9:37 ` Daniel P. Berrangé
2019-07-01 9:57 ` P J P
2019-07-01 9:21 ` [Qemu-devel] [PATCH v2 0/3] restrict bridge interface " no-reply
2019-07-01 10:08 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701094420.GG3573@redhat.com \
--to=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=liq3ea@gmail.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rschiron@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).