From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D374C0650E for ; Mon, 1 Jul 2019 09:11:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 040BA213F2 for ; Mon, 1 Jul 2019 09:11:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 040BA213F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhsLf-0004vV-14 for qemu-devel@archiver.kernel.org; Mon, 01 Jul 2019 05:11:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44563) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhsJE-0002gz-4M for qemu-devel@nongnu.org; Mon, 01 Jul 2019 05:09:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhsJC-0005ZE-OS for qemu-devel@nongnu.org; Mon, 01 Jul 2019 05:09:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57896) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hhsJC-0005Cc-H6 for qemu-devel@nongnu.org; Mon, 01 Jul 2019 05:09:10 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 96C5530872EE; Mon, 1 Jul 2019 09:08:41 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D3D01001B33; Mon, 1 Jul 2019 09:08:40 +0000 (UTC) Date: Mon, 1 Jul 2019 11:08:36 +0200 From: Igor Mammedov To: Michael Rolnik Message-ID: <20190701110836.48f433f6@redhat.com> In-Reply-To: References: <20190628120118.78920-1-mrolnik@gmail.com> <20190628120118.78920-2-mrolnik@gmail.com> <20190628151022.02946447@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 01 Jul 2019 09:08:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v24 1/7] target/avr: Add outward facing interfaces and core CPU logic X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 28 Jun 2019 18:54:27 +0300 Michael Rolnik wrote: > Igor. > > so avr6 instead of a6-avr-cpu, xmega2 instead of xmega2-avr-cpu and so on, > right? (it would be better if question was rith under context that prompted it) [...] > > > +++ b/target/avr/cpu.h > > > @@ -0,0 +1,283 @@ > > > +/* > > > + * QEMU AVR CPU > > > + * > > > + * Copyright (c) 2016 Michael Rolnik > > > + * > > > + * This library is free software; you can redistribute it and/or > > > + * modify it under the terms of the GNU Lesser General Public > > > + * License as published by the Free Software Foundation; either > > > + * version 2.1 of the License, or (at your option) any later version. > > > + * > > > + * This library is distributed in the hope that it will be useful, > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > > + * Lesser General Public License for more details. > > > + * > > > + * You should have received a copy of the GNU Lesser General Public > > > + * License along with this library; if not, see > > > + * > > > + */ > > > + > > > +#ifndef CPU_AVR_H > > > +#define CPU_AVR_H > > > + > > > +#include "qemu-common.h" > > > +#include "qom/cpu.h" > > > +#include "exec/cpu-defs.h" > > > +#include "fpu/softfloat.h" > > > + > > > +#define TCG_GUEST_DEFAULT_MO 0 > > > + > > > +#define TYPE_AVR_CPU "avr-cpu" > > > + > > > +#define AVR_CPU_TYPE_SUFFIX "-" TYPE_AVR_CPU > > > +#define AVR_CPU_TYPE_NAME(name) (name AVR_CPU_TYPE_SUFFIX) > > we probably can do without above macro and opencode typenames > > directly since we don't have 'model' notion and don't need > > translate it into typename anymore. I'd guess question was about that part. What I've meant is to replace AVR_CPU_TYPE_NAME("avr6") and etc with "avr6-avr-cpu" or even better with macro TYPE_AVR6_CPU "avr6-avr-cpu" use it through out the code and do the same for other sub-types [...]