From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FB7C06511 for ; Mon, 1 Jul 2019 11:28:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 964FF206A3 for ; Mon, 1 Jul 2019 11:28:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 964FF206A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhuTw-0008Vi-Rr for qemu-devel@archiver.kernel.org; Mon, 01 Jul 2019 07:28:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45108) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhuS3-00061g-33 for qemu-devel@nongnu.org; Mon, 01 Jul 2019 07:26:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhuS1-0007ec-4A for qemu-devel@nongnu.org; Mon, 01 Jul 2019 07:26:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54200) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hhuS0-0007ct-UY for qemu-devel@nongnu.org; Mon, 01 Jul 2019 07:26:25 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E84B33082231; Mon, 1 Jul 2019 11:26:21 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.170]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E2C71B4B0; Mon, 1 Jul 2019 11:26:19 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Mon, 1 Jul 2019 13:26:09 +0200 Message-Id: <20190701112612.14758-2-philmd@redhat.com> In-Reply-To: <20190701112612.14758-1-philmd@redhat.com> References: <20190701112612.14758-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 01 Jul 2019 11:26:22 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4 1/4] hw/mips: Explicit the semi-hosting feature is always required X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Markovic Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Disabling the semi-hosting feature leads to build failure: LINK mips-softmmu/qemu-system-mips /usr/bin/ld: target/mips/mips-semi.o: in function `helper_do_semihostin= g': target/mips/mips-semi.c:335: undefined reference to `qemu_semihosting_l= og_out' /usr/bin/ld: target/mips/mips-semi.c:338: undefined reference to `qemu_= semihosting_log_out' collect2: error: ld returned 1 exit status Add a comment to avoid this feature to be disabled. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- default-configs/mips-softmmu-common.mak | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mi= ps-softmmu-common.mak index e10ac4b20c..1ea47a9c2a 100644 --- a/default-configs/mips-softmmu-common.mak +++ b/default-configs/mips-softmmu-common.mak @@ -1,5 +1,8 @@ # Common mips*-softmmu CONFIG defines =20 +# CONFIG_SEMIHOSTING is always required on this architecture +CONFIG_SEMIHOSTING=3Dy + CONFIG_ISA_BUS=3Dy CONFIG_PCI=3Dy CONFIG_PCI_DEVICES=3Dy @@ -35,7 +38,6 @@ CONFIG_MIPS_CPS=3Dy CONFIG_MIPS_ITU=3Dy CONFIG_R4K=3Dy CONFIG_MALTA=3Dy -CONFIG_SEMIHOSTING=3Dy CONFIG_PCNET_PCI=3Dy CONFIG_MIPSSIM=3Dy CONFIG_ACPI_SMBUS=3Dy --=20 2.20.1