* [Qemu-devel] [PATCH] migration: move port_attr inside CONFIG_LINUX
@ 2019-07-01 16:47 Alex Bennée
2019-07-01 16:57 ` Peter Maydell
2019-07-02 8:43 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Alex Bennée @ 2019-07-01 16:47 UTC (permalink / raw)
To: peter.maydell
Cc: Alex Bennée, qemu-devel, Dr. David Alan Gilbert,
Juan Quintela
Otherwise the FreeBSD compiler complains about an unused variable.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
migration/rdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 74cb2aa9f9..3036221ee8 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -839,10 +839,9 @@ static void qemu_rdma_dump_gid(const char *who, struct rdma_cm_id *id)
*/
static int qemu_rdma_broken_ipv6_kernel(struct ibv_context *verbs, Error **errp)
{
- struct ibv_port_attr port_attr;
-
/* This bug only exists in linux, to our knowledge. */
#ifdef CONFIG_LINUX
+ struct ibv_port_attr port_attr;
/*
* Verbs are only NULL if management has bound to '[::]'.
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: move port_attr inside CONFIG_LINUX
2019-07-01 16:47 [Qemu-devel] [PATCH] migration: move port_attr inside CONFIG_LINUX Alex Bennée
@ 2019-07-01 16:57 ` Peter Maydell
2019-07-02 8:43 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2019-07-01 16:57 UTC (permalink / raw)
To: Alex Bennée; +Cc: QEMU Developers, Dr. David Alan Gilbert, Juan Quintela
On Mon, 1 Jul 2019 at 17:47, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Otherwise the FreeBSD compiler complains about an unused variable.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> migration/rdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 74cb2aa9f9..3036221ee8 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -839,10 +839,9 @@ static void qemu_rdma_dump_gid(const char *who, struct rdma_cm_id *id)
> */
> static int qemu_rdma_broken_ipv6_kernel(struct ibv_context *verbs, Error **errp)
> {
> - struct ibv_port_attr port_attr;
> -
> /* This bug only exists in linux, to our knowledge. */
> #ifdef CONFIG_LINUX
> + struct ibv_port_attr port_attr;
>
> /*
> * Verbs are only NULL if management has bound to '[::]'.
> --
> 2.20.1
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: move port_attr inside CONFIG_LINUX
2019-07-01 16:47 [Qemu-devel] [PATCH] migration: move port_attr inside CONFIG_LINUX Alex Bennée
2019-07-01 16:57 ` Peter Maydell
@ 2019-07-02 8:43 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-07-02 8:43 UTC (permalink / raw)
To: Alex Bennée, peter.maydell
Cc: Juan Quintela, qemu-devel, Dr. David Alan Gilbert
On 7/1/19 6:47 PM, Alex Bennée wrote:
> Otherwise the FreeBSD compiler complains about an unused variable.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> migration/rdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 74cb2aa9f9..3036221ee8 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -839,10 +839,9 @@ static void qemu_rdma_dump_gid(const char *who, struct rdma_cm_id *id)
> */
> static int qemu_rdma_broken_ipv6_kernel(struct ibv_context *verbs, Error **errp)
> {
> - struct ibv_port_attr port_attr;
> -
> /* This bug only exists in linux, to our knowledge. */
> #ifdef CONFIG_LINUX
> + struct ibv_port_attr port_attr;
>
> /*
> * Verbs are only NULL if management has bound to '[::]'.
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-02 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-01 16:47 [Qemu-devel] [PATCH] migration: move port_attr inside CONFIG_LINUX Alex Bennée
2019-07-01 16:57 ` Peter Maydell
2019-07-02 8:43 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).