From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-block@nongnu.org, "Aleksandar Rikalo" <arikalo@wavecomp.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-arm@nongnu.org, "Alistair Francis" <alistair23@gmail.com>,
"John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"Michael Walle" <michael@walle.cc>,
qemu-ppc@nongnu.org, "Wei Yang" <richardw.yang@linux.intel.com>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v2 0/9] hw/block/pflash_cfi01: Add DeviceReset() handler
Date: Tue, 2 Jul 2019 02:12:52 +0200 [thread overview]
Message-ID: <20190702001301.4768-1-philmd@redhat.com> (raw)
The pflash device lacks a reset() function.
When a machine is resetted, the flash might be in an
inconsistent state, leading to unexpected behavior:
https://bugzilla.redhat.com/show_bug.cgi?id=1678713
Resolve this issue by adding a DeviceReset() handler.
Fix also two minor issues, and clean a bit the codebase.
Since v1: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg00962.html
- addressed Laszlo review comments
Maintainers spam list from:
./scripts/get_maintainer.pl -f $(git grep -El '(pflash_cfi01_register|TYPE_PFLASH_CFI01)')
Regards,
Phil.
Philippe Mathieu-Daudé (9):
hw/block/pflash_cfi01: Removed an unused timer
hw/block/pflash_cfi01: Use the correct READ_ARRAY value
hw/block/pflash_cfi01: Extract pflash_mode_read_array()
hw/block/pflash_cfi01: Start state machine as READY to accept commands
hw/block/pflash_cfi01: Add the DeviceReset() handler
hw/block/pflash_cfi01: Simplify CFI_QUERY processing
hw/block/pflash_cfi01: Improve command comments
hw/block/pflash_cfi01: Replace DPRINTF by qemu_log_mask(GUEST_ERROR)
hw/block/pflash_cfi01: Hold the PRI table offset in a variable
hw/block/pflash_cfi01.c | 140 +++++++++++++++++++++-------------------
hw/block/trace-events | 1 +
2 files changed, 74 insertions(+), 67 deletions(-)
--
2.20.1
next reply other threads:[~2019-07-02 2:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 0:12 Philippe Mathieu-Daudé [this message]
2019-07-02 0:12 ` [Qemu-devel] [PATCH v2 1/9] hw/block/pflash_cfi01: Removed an unused timer Philippe Mathieu-Daudé
2019-07-02 15:58 ` Alistair Francis
2019-07-02 0:12 ` [Qemu-devel] [PATCH v2 2/9] hw/block/pflash_cfi01: Use the correct READ_ARRAY value Philippe Mathieu-Daudé
2019-07-02 2:54 ` John Snow
2019-07-02 15:59 ` Alistair Francis
2019-07-02 0:12 ` [Qemu-devel] [PATCH v2 3/9] hw/block/pflash_cfi01: Extract pflash_mode_read_array() Philippe Mathieu-Daudé
2019-07-02 3:01 ` John Snow
2019-07-02 16:01 ` Alistair Francis
2019-07-02 0:12 ` [Qemu-devel] [PATCH v2 4/9] hw/block/pflash_cfi01: Start state machine as READY to accept commands Philippe Mathieu-Daudé
2019-07-02 3:04 ` John Snow
2019-07-02 16:02 ` Alistair Francis
2019-07-02 0:12 ` [Qemu-devel] [PATCH v2 5/9] hw/block/pflash_cfi01: Add the DeviceReset() handler Philippe Mathieu-Daudé
2019-07-02 3:16 ` John Snow
2019-07-02 9:23 ` Peter Maydell
2019-07-02 9:37 ` Philippe Mathieu-Daudé
2019-07-02 14:32 ` Laszlo Ersek
2019-07-02 12:30 ` John Snow
2019-07-02 12:14 ` Laszlo Ersek
2019-07-02 0:12 ` [Qemu-devel] [PATCH v2 6/9] hw/block/pflash_cfi01: Simplify CFI_QUERY processing Philippe Mathieu-Daudé
2019-07-02 16:03 ` Alistair Francis
2019-07-02 0:12 ` [Qemu-devel] [PATCH v2 7/9] hw/block/pflash_cfi01: Improve command comments Philippe Mathieu-Daudé
2019-07-02 16:13 ` Alistair Francis
2019-07-02 0:13 ` [Qemu-devel] [PATCH v2 8/9] hw/block/pflash_cfi01: Replace DPRINTF by qemu_log_mask(GUEST_ERROR) Philippe Mathieu-Daudé
2019-07-02 16:15 ` Alistair Francis
2019-07-02 0:13 ` [Qemu-devel] [PATCH v2 9/9] hw/block/pflash_cfi01: Hold the PRI table offset in a variable Philippe Mathieu-Daudé
2019-07-02 16:17 ` Alistair Francis
2019-07-02 6:15 ` [Qemu-devel] [PATCH v2 0/9] hw/block/pflash_cfi01: Add DeviceReset() handler no-reply
2019-07-02 10:17 ` Philippe Mathieu-Daudé
2019-07-02 11:52 ` Laszlo Ersek
2019-07-02 13:41 ` Laszlo Ersek
2019-07-02 21:00 ` Laszlo Ersek
2019-07-02 15:28 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702001301.4768-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alistair23@gmail.com \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=michael@walle.cc \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richardw.yang@linux.intel.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).