Re: [Qemu-devel] [PATCH v2 4/9] i386: Register versioned CPU models

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jun 27, 2019 at 09:28:39PM -0300, Eduardo Habkost wrote:
> Add support for registration of multiple versions of CPU models.
> 
> The existing CPU models will be registered with a "-v1" suffix.
> 
> The -noTSX, -IBRS, and -IBPB CPU model variants will become
> versions of the original models in a separate patch, so
> make sure we register no versions for them.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Patch v1 was "[PATCH 4/6] i386: Infrastructure for versioned CPU
> models", and was split into multiple patches.
> 
> Changes v1 -> v2:
> * Make version numbers simple integers, completely independent
>   from machine type versions
> * Don't register versions for -noTSX, -IBRS, and -IBPB CPU models
> * Code for reporting alias-of on query-cpu-definitions is now in
>   a separate patch
> * Code for machine-type compatibility is now in a separate patch
> * New X86CPUVersion typedef
> * New CPU_VERSION_* defines to make X86CPUModel::version
>   semantics clearer
> ---
>  target/i386/cpu-qom.h                      |  10 +-
>  target/i386/cpu.h                          |  10 +
>  target/i386/cpu.c                          | 223 +++++++++++++++++++--
>  tests/acceptance/x86_cpu_model_versions.py | 105 ++++++++++
>  4 files changed, 318 insertions(+), 30 deletions(-)
>  create mode 100644 tests/acceptance/x86_cpu_model_versions.py

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|