From: Stefano Garzarella <sgarzare@redhat.com>
To: Julio Montes <julio.montes@intel.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH] monitor: vnc: Fix compilation error if CONFIG_VNC is disable
Date: Wed, 3 Jul 2019 10:21:59 +0200 [thread overview]
Message-ID: <20190703082159.ewnjivevv2wzmdxm@steredhat> (raw)
In-Reply-To: <20190702190131.5780-1-julio.montes@intel.com>
On Tue, Jul 02, 2019 at 07:01:31PM +0000, Julio Montes wrote:
> How to reproduce it?
> ===
>
> ```
> $ ./configure --disable-spice --disable-vte --disable-vnc \
> --disable-vnc-jpeg --disable-vnc-png --disable-vnc-sasl
> $ make
> ...
> monitor/hmp-cmds.c: In function ‘hmp_change’:
> monitor/hmp-cmds.c:1985:17: error: unused variable ‘hmp_mon’
> [-Werror=unused-variable]
> MonitorHMP *hmp_mon = container_of(mon, MonitorHMP, common);
> ```
>
> Fix
> ===
>
> Move `hmp_mon` variable within the `CONFIG_VNC` block
>
Hi Julio,
thanks for the patch, but Christophe sent a very similar patch last
week: https://patchew.org/QEMU/20190625123905.25434-1-dinechin@redhat.com/
Cheers,
Stefano
next prev parent reply other threads:[~2019-07-03 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 19:01 [Qemu-devel] [PATCH] monitor: vnc: Fix compilation error if CONFIG_VNC is disable Julio Montes
2019-07-03 1:40 ` no-reply
2019-07-03 8:21 ` Stefano Garzarella [this message]
2019-07-03 13:23 ` Montes, Julio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703082159.ewnjivevv2wzmdxm@steredhat \
--to=sgarzare@redhat.com \
--cc=dgilbert@redhat.com \
--cc=julio.montes@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).