* [Qemu-devel] [PULL 0/4] Vga 20190703 patches @ 2019-07-03 8:54 Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 1/4] virtio-gpu: fix unmap in error path Gerd Hoffmann ` (7 more replies) 0 siblings, 8 replies; 9+ messages in thread From: Gerd Hoffmann @ 2019-07-03 8:54 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Michael S. Tsirkin, qemu-arm, qemu-ppc, Gerd Hoffmann, David Gibson The following changes since commit 506179e42112be77bfd071f050b15762d3b2cd43: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190702' into staging (2019-07-02 18:56:44 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20190703-pull-request for you to fetch changes up to 0a87fd693d4e955a6877a2166b65bb7b7192aaaa: Add ati vgabios to INSTALL_BLOBS. (2019-07-03 10:52:15 +0200) ---------------------------------------------------------------- vga: virtio fixes, bitbang i2c asan fix, install ati vgabios. ---------------------------------------------------------------- Gerd Hoffmann (2): virtio-gpu: fix unmap in error path Add ati vgabios to INSTALL_BLOBS. Li Qiang (1): virtio-gpu: check if the resource already exists in virtio_gpu_load() Peter Maydell (1): hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct Makefile | 2 +- hw/display/ati_int.h | 2 +- include/hw/i2c/bitbang_i2c.h | 38 ++++++++++++++++++++++++++++- include/hw/i2c/ppc4xx_i2c.h | 2 +- hw/display/ati.c | 7 +++--- hw/display/virtio-gpu.c | 9 +++++-- hw/i2c/bitbang_i2c.c | 47 +++--------------------------------- hw/i2c/ppc4xx_i2c.c | 6 ++--- hw/i2c/versatile_i2c.c | 8 +++--- 9 files changed, 61 insertions(+), 60 deletions(-) -- 2.18.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] [PULL 1/4] virtio-gpu: fix unmap in error path 2019-07-03 8:54 [Qemu-devel] [PULL 0/4] Vga 20190703 patches Gerd Hoffmann @ 2019-07-03 8:54 ` Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 2/4] virtio-gpu: check if the resource already exists in virtio_gpu_load() Gerd Hoffmann ` (6 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Gerd Hoffmann @ 2019-07-03 8:54 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Michael S. Tsirkin, qemu-arm, qemu-ppc, Gerd Hoffmann, David Gibson We land here in case not everything we've asked for could be mapped. So unmap only the bytes which have actually been mapped. Also we didn't access anything, so acces_len can be 0. Reported-by: Laszlo Ersek <lersek@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Li Qiang <liq3ea@gmail.com> Message-id: 20190628072357.31782-1-kraxel@redhat.com --- hw/display/virtio-gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 2b0f66b1d68d..475a018c027c 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -1048,9 +1048,9 @@ static int virtio_gpu_load(QEMUFile *f, void *opaque, size_t size, if (res->iov[i].iov_base) { dma_memory_unmap(VIRTIO_DEVICE(g)->dma_as, res->iov[i].iov_base, - res->iov[i].iov_len, + len, DMA_DIRECTION_TO_DEVICE, - res->iov[i].iov_len); + 0); } /* ...and the mappings for previous loop iterations */ res->iov_cnt = i; -- 2.18.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Qemu-devel] [PULL 2/4] virtio-gpu: check if the resource already exists in virtio_gpu_load() 2019-07-03 8:54 [Qemu-devel] [PULL 0/4] Vga 20190703 patches Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 1/4] virtio-gpu: fix unmap in error path Gerd Hoffmann @ 2019-07-03 8:54 ` Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 3/4] hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct Gerd Hoffmann ` (5 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Gerd Hoffmann @ 2019-07-03 8:54 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Michael S. Tsirkin, Li Qiang, qemu-arm, qemu-ppc, Gerd Hoffmann, David Gibson From: Li Qiang <liq3ea@163.com> While loading virtio-gpu, the data can be malicious, we should check if the resource already exists. Signed-off-by: Li Qiang <liq3ea@163.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-id: 20190628161358.10400-1-liq3ea@163.com Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- hw/display/virtio-gpu.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 475a018c027c..25d9e327fc69 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -1002,6 +1002,11 @@ static int virtio_gpu_load(QEMUFile *f, void *opaque, size_t size, resource_id = qemu_get_be32(f); while (resource_id != 0) { + res = virtio_gpu_find_resource(g, resource_id); + if (res) { + return -EINVAL; + } + res = g_new0(struct virtio_gpu_simple_resource, 1); res->resource_id = resource_id; res->width = qemu_get_be32(f); -- 2.18.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Qemu-devel] [PULL 3/4] hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct 2019-07-03 8:54 [Qemu-devel] [PULL 0/4] Vga 20190703 patches Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 1/4] virtio-gpu: fix unmap in error path Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 2/4] virtio-gpu: check if the resource already exists in virtio_gpu_load() Gerd Hoffmann @ 2019-07-03 8:54 ` Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 4/4] Add ati vgabios to INSTALL_BLOBS Gerd Hoffmann ` (4 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Gerd Hoffmann @ 2019-07-03 8:54 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Michael S. Tsirkin, qemu-arm, qemu-ppc, Gerd Hoffmann, David Gibson From: Peter Maydell <peter.maydell@linaro.org> Currently the bitbang_i2c_init() function allocates a bitbang_i2c_interface struct which it returns. This is unfortunate because it means that if the function is used from a DeviceState init method then the memory will be leaked by an "init then delete" cycle, as used by the qmp/hmp commands that list device properties. Since three out of four of the uses of this function are in device init methods, switch the function to do an in-place initialization of a struct that can be embedded in the device state struct of the caller. This fixes LeakSanitizer leak warnings that have appeared in the patchew configuration (which only tries to run the sanitizers for the x86_64-softmmu target) now that we use the bitbang-i2c code in an x86-64 config. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> Tested-by: BALATON Zoltan <balaton@eik.bme.hu> Acked-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-id: 20190702163844.20458-1-peter.maydell@linaro.org Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- hw/display/ati_int.h | 2 +- include/hw/i2c/bitbang_i2c.h | 38 ++++++++++++++++++++++++++++- include/hw/i2c/ppc4xx_i2c.h | 2 +- hw/display/ati.c | 7 +++--- hw/i2c/bitbang_i2c.c | 47 +++--------------------------------- hw/i2c/ppc4xx_i2c.c | 6 ++--- hw/i2c/versatile_i2c.c | 8 +++--- 7 files changed, 53 insertions(+), 57 deletions(-) diff --git a/hw/display/ati_int.h b/hw/display/ati_int.h index 9b67d0022ad9..31a1927b3ecb 100644 --- a/hw/display/ati_int.h +++ b/hw/display/ati_int.h @@ -88,7 +88,7 @@ typedef struct ATIVGAState { uint16_t cursor_size; uint32_t cursor_offset; QEMUCursor *cursor; - bitbang_i2c_interface *bbi2c; + bitbang_i2c_interface bbi2c; MemoryRegion io; MemoryRegion mm; ATIVGARegs regs; diff --git a/include/hw/i2c/bitbang_i2c.h b/include/hw/i2c/bitbang_i2c.h index 3a7126d5dee8..92334e9016a8 100644 --- a/include/hw/i2c/bitbang_i2c.h +++ b/include/hw/i2c/bitbang_i2c.h @@ -8,7 +8,43 @@ typedef struct bitbang_i2c_interface bitbang_i2c_interface; #define BITBANG_I2C_SDA 0 #define BITBANG_I2C_SCL 1 -bitbang_i2c_interface *bitbang_i2c_init(I2CBus *bus); +typedef enum bitbang_i2c_state { + STOPPED = 0, + SENDING_BIT7, + SENDING_BIT6, + SENDING_BIT5, + SENDING_BIT4, + SENDING_BIT3, + SENDING_BIT2, + SENDING_BIT1, + SENDING_BIT0, + WAITING_FOR_ACK, + RECEIVING_BIT7, + RECEIVING_BIT6, + RECEIVING_BIT5, + RECEIVING_BIT4, + RECEIVING_BIT3, + RECEIVING_BIT2, + RECEIVING_BIT1, + RECEIVING_BIT0, + SENDING_ACK, + SENT_NACK +} bitbang_i2c_state; + +struct bitbang_i2c_interface { + I2CBus *bus; + bitbang_i2c_state state; + int last_data; + int last_clock; + int device_out; + uint8_t buffer; + int current_addr; +}; + +/** + * bitbang_i2c_init: in-place initialize the bitbang_i2c_interface struct + */ +void bitbang_i2c_init(bitbang_i2c_interface *s, I2CBus *bus); int bitbang_i2c_set(bitbang_i2c_interface *i2c, int line, int level); #endif diff --git a/include/hw/i2c/ppc4xx_i2c.h b/include/hw/i2c/ppc4xx_i2c.h index 8437bf070b8b..f6f837fbec00 100644 --- a/include/hw/i2c/ppc4xx_i2c.h +++ b/include/hw/i2c/ppc4xx_i2c.h @@ -41,7 +41,7 @@ typedef struct PPC4xxI2CState { I2CBus *bus; qemu_irq irq; MemoryRegion iomem; - bitbang_i2c_interface *bitbang; + bitbang_i2c_interface bitbang; int mdidx; uint8_t mdata[4]; uint8_t lmadr; diff --git a/hw/display/ati.c b/hw/display/ati.c index 0cb117384839..c1d9d1518f4a 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -538,7 +538,7 @@ static void ati_mm_write(void *opaque, hwaddr addr, break; case GPIO_DVI_DDC: if (s->dev_id != PCI_DEVICE_ID_ATI_RAGE128_PF) { - s->regs.gpio_dvi_ddc = ati_i2c(s->bbi2c, data, 0); + s->regs.gpio_dvi_ddc = ati_i2c(&s->bbi2c, data, 0); } break; case GPIO_MONID ... GPIO_MONID + 3: @@ -554,7 +554,7 @@ static void ati_mm_write(void *opaque, hwaddr addr, */ if ((s->regs.gpio_monid & BIT(25)) && addr <= GPIO_MONID + 2 && addr + size > GPIO_MONID + 2) { - s->regs.gpio_monid = ati_i2c(s->bbi2c, s->regs.gpio_monid, 1); + s->regs.gpio_monid = ati_i2c(&s->bbi2c, s->regs.gpio_monid, 1); } } break; @@ -856,7 +856,7 @@ static void ati_vga_realize(PCIDevice *dev, Error **errp) /* ddc, edid */ I2CBus *i2cbus = i2c_init_bus(DEVICE(s), "ati-vga.ddc"); - s->bbi2c = bitbang_i2c_init(i2cbus); + bitbang_i2c_init(&s->bbi2c, i2cbus); I2CSlave *i2cddc = I2C_SLAVE(qdev_create(BUS(i2cbus), TYPE_I2CDDC)); i2c_set_slave_address(i2cddc, 0x50); @@ -885,7 +885,6 @@ static void ati_vga_exit(PCIDevice *dev) ATIVGAState *s = ATI_VGA(dev); graphic_console_close(s->vga.con); - g_free(s->bbi2c); } static Property ati_vga_properties[] = { diff --git a/hw/i2c/bitbang_i2c.c b/hw/i2c/bitbang_i2c.c index 3cb0509b0200..60c7a9be0bca 100644 --- a/hw/i2c/bitbang_i2c.c +++ b/hw/i2c/bitbang_i2c.c @@ -25,39 +25,6 @@ do { printf("bitbang_i2c: " fmt , ## __VA_ARGS__); } while (0) #define DPRINTF(fmt, ...) do {} while(0) #endif -typedef enum bitbang_i2c_state { - STOPPED = 0, - SENDING_BIT7, - SENDING_BIT6, - SENDING_BIT5, - SENDING_BIT4, - SENDING_BIT3, - SENDING_BIT2, - SENDING_BIT1, - SENDING_BIT0, - WAITING_FOR_ACK, - RECEIVING_BIT7, - RECEIVING_BIT6, - RECEIVING_BIT5, - RECEIVING_BIT4, - RECEIVING_BIT3, - RECEIVING_BIT2, - RECEIVING_BIT1, - RECEIVING_BIT0, - SENDING_ACK, - SENT_NACK -} bitbang_i2c_state; - -struct bitbang_i2c_interface { - I2CBus *bus; - bitbang_i2c_state state; - int last_data; - int last_clock; - int device_out; - uint8_t buffer; - int current_addr; -}; - static void bitbang_i2c_enter_stop(bitbang_i2c_interface *i2c) { DPRINTF("STOP\n"); @@ -184,18 +151,12 @@ int bitbang_i2c_set(bitbang_i2c_interface *i2c, int line, int level) abort(); } -bitbang_i2c_interface *bitbang_i2c_init(I2CBus *bus) +void bitbang_i2c_init(bitbang_i2c_interface *s, I2CBus *bus) { - bitbang_i2c_interface *s; - - s = g_malloc0(sizeof(bitbang_i2c_interface)); - s->bus = bus; s->last_data = 1; s->last_clock = 1; s->device_out = 1; - - return s; } /* GPIO interface. */ @@ -207,7 +168,7 @@ typedef struct GPIOI2CState { SysBusDevice parent_obj; MemoryRegion dummy_iomem; - bitbang_i2c_interface *bitbang; + bitbang_i2c_interface bitbang; int last_level; qemu_irq out; } GPIOI2CState; @@ -216,7 +177,7 @@ static void bitbang_i2c_gpio_set(void *opaque, int irq, int level) { GPIOI2CState *s = opaque; - level = bitbang_i2c_set(s->bitbang, irq, level); + level = bitbang_i2c_set(&s->bitbang, irq, level); if (level != s->last_level) { s->last_level = level; qemu_set_irq(s->out, level); @@ -234,7 +195,7 @@ static void gpio_i2c_init(Object *obj) sysbus_init_mmio(sbd, &s->dummy_iomem); bus = i2c_init_bus(dev, "i2c"); - s->bitbang = bitbang_i2c_init(bus); + bitbang_i2c_init(&s->bitbang, bus); qdev_init_gpio_in(dev, bitbang_i2c_gpio_set, 2); qdev_init_gpio_out(dev, &s->out, 1); diff --git a/hw/i2c/ppc4xx_i2c.c b/hw/i2c/ppc4xx_i2c.c index 5fb4f86c38f1..462729db4ea7 100644 --- a/hw/i2c/ppc4xx_i2c.c +++ b/hw/i2c/ppc4xx_i2c.c @@ -311,9 +311,9 @@ static void ppc4xx_i2c_writeb(void *opaque, hwaddr addr, uint64_t value, case IIC_DIRECTCNTL: i2c->directcntl = value & (IIC_DIRECTCNTL_SDAC & IIC_DIRECTCNTL_SCLC); i2c->directcntl |= (value & IIC_DIRECTCNTL_SCLC ? 1 : 0); - bitbang_i2c_set(i2c->bitbang, BITBANG_I2C_SCL, + bitbang_i2c_set(&i2c->bitbang, BITBANG_I2C_SCL, i2c->directcntl & IIC_DIRECTCNTL_MSCL); - i2c->directcntl |= bitbang_i2c_set(i2c->bitbang, BITBANG_I2C_SDA, + i2c->directcntl |= bitbang_i2c_set(&i2c->bitbang, BITBANG_I2C_SDA, (value & IIC_DIRECTCNTL_SDAC) != 0) << 1; break; default: @@ -347,7 +347,7 @@ static void ppc4xx_i2c_init(Object *o) sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->iomem); sysbus_init_irq(SYS_BUS_DEVICE(s), &s->irq); s->bus = i2c_init_bus(DEVICE(s), "i2c"); - s->bitbang = bitbang_i2c_init(s->bus); + bitbang_i2c_init(&s->bitbang, s->bus); } static void ppc4xx_i2c_class_init(ObjectClass *klass, void *data) diff --git a/hw/i2c/versatile_i2c.c b/hw/i2c/versatile_i2c.c index 24b6e36b6d52..1ac2a6f59a0a 100644 --- a/hw/i2c/versatile_i2c.c +++ b/hw/i2c/versatile_i2c.c @@ -35,7 +35,7 @@ typedef struct VersatileI2CState { SysBusDevice parent_obj; MemoryRegion iomem; - bitbang_i2c_interface *bitbang; + bitbang_i2c_interface bitbang; int out; int in; } VersatileI2CState; @@ -70,8 +70,8 @@ static void versatile_i2c_write(void *opaque, hwaddr offset, qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad offset 0x%x\n", __func__, (int)offset); } - bitbang_i2c_set(s->bitbang, BITBANG_I2C_SCL, (s->out & 1) != 0); - s->in = bitbang_i2c_set(s->bitbang, BITBANG_I2C_SDA, (s->out & 2) != 0); + bitbang_i2c_set(&s->bitbang, BITBANG_I2C_SCL, (s->out & 1) != 0); + s->in = bitbang_i2c_set(&s->bitbang, BITBANG_I2C_SDA, (s->out & 2) != 0); } static const MemoryRegionOps versatile_i2c_ops = { @@ -88,7 +88,7 @@ static void versatile_i2c_init(Object *obj) I2CBus *bus; bus = i2c_init_bus(dev, "i2c"); - s->bitbang = bitbang_i2c_init(bus); + bitbang_i2c_init(&s->bitbang, bus); memory_region_init_io(&s->iomem, obj, &versatile_i2c_ops, s, "versatile_i2c", 0x1000); sysbus_init_mmio(sbd, &s->iomem); -- 2.18.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Qemu-devel] [PULL 4/4] Add ati vgabios to INSTALL_BLOBS. 2019-07-03 8:54 [Qemu-devel] [PULL 0/4] Vga 20190703 patches Gerd Hoffmann ` (2 preceding siblings ...) 2019-07-03 8:54 ` [Qemu-devel] [PULL 3/4] hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct Gerd Hoffmann @ 2019-07-03 8:54 ` Gerd Hoffmann 2019-07-04 7:45 ` [Qemu-devel] [PULL 0/4] Vga 20190703 patches Peter Maydell ` (3 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Gerd Hoffmann @ 2019-07-03 8:54 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Michael S. Tsirkin, qemu-arm, qemu-ppc, Gerd Hoffmann, David Gibson Fixes: 0cca7e7bfd6c81cc3c29ec2b3a0a98954c4ba71a Reported-by: Bruce Rogers <BROGERS@suse.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Message-id: 20190703045212.31039-1-kraxel@redhat.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b1c93ac02721..d657df904166 100644 --- a/Makefile +++ b/Makefile @@ -750,7 +750,7 @@ bepo cz ifdef INSTALL_BLOBS BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \ vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \ -vgabios-ramfb.bin vgabios-bochs-display.bin \ +vgabios-ramfb.bin vgabios-bochs-display.bin vgabios-ati.bin \ ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \ pxe-e1000.rom pxe-eepro100.rom pxe-ne2k_pci.rom \ pxe-pcnet.rom pxe-rtl8139.rom pxe-virtio.rom \ -- 2.18.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PULL 0/4] Vga 20190703 patches 2019-07-03 8:54 [Qemu-devel] [PULL 0/4] Vga 20190703 patches Gerd Hoffmann ` (3 preceding siblings ...) 2019-07-03 8:54 ` [Qemu-devel] [PULL 4/4] Add ati vgabios to INSTALL_BLOBS Gerd Hoffmann @ 2019-07-04 7:45 ` Peter Maydell 2019-07-04 8:05 ` no-reply ` (2 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Peter Maydell @ 2019-07-04 7:45 UTC (permalink / raw) To: Gerd Hoffmann Cc: Michael S. Tsirkin, qemu-arm, qemu-ppc, QEMU Developers, David Gibson On Wed, 3 Jul 2019 at 09:54, Gerd Hoffmann <kraxel@redhat.com> wrote: > > The following changes since commit 506179e42112be77bfd071f050b15762d3b2cd43: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190702' into staging (2019-07-02 18:56:44 +0100) > > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/vga-20190703-pull-request > > for you to fetch changes up to 0a87fd693d4e955a6877a2166b65bb7b7192aaaa: > > Add ati vgabios to INSTALL_BLOBS. (2019-07-03 10:52:15 +0200) > > ---------------------------------------------------------------- > vga: virtio fixes, bitbang i2c asan fix, install ati vgabios. > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.1 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PULL 0/4] Vga 20190703 patches 2019-07-03 8:54 [Qemu-devel] [PULL 0/4] Vga 20190703 patches Gerd Hoffmann ` (4 preceding siblings ...) 2019-07-04 7:45 ` [Qemu-devel] [PULL 0/4] Vga 20190703 patches Peter Maydell @ 2019-07-04 8:05 ` no-reply 2019-07-04 8:35 ` no-reply 2019-07-04 9:08 ` no-reply 7 siblings, 0 replies; 9+ messages in thread From: no-reply @ 2019-07-04 8:05 UTC (permalink / raw) To: kraxel; +Cc: peter.maydell, mst, qemu-devel, qemu-arm, qemu-ppc, kraxel, david Patchew URL: https://patchew.org/QEMU/20190703085416.21837-1-kraxel@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190703085416.21837-1-kraxel@redhat.com Subject: [Qemu-devel] [PULL 0/4] Vga 20190703 patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu c204e34..f0577c6 master -> master - [tag update] patchew/20190703085416.21837-1-kraxel@redhat.com -> patchew/20190703085416.21837-1-kraxel@redhat.com Switched to a new branch 'test' === OUTPUT BEGIN === checkpatch.pl: no revisions returned for revlist '1' === OUTPUT END === Test command exited with code: 255 The full log is available at http://patchew.org/logs/20190703085416.21837-1-kraxel@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PULL 0/4] Vga 20190703 patches 2019-07-03 8:54 [Qemu-devel] [PULL 0/4] Vga 20190703 patches Gerd Hoffmann ` (5 preceding siblings ...) 2019-07-04 8:05 ` no-reply @ 2019-07-04 8:35 ` no-reply 2019-07-04 9:08 ` no-reply 7 siblings, 0 replies; 9+ messages in thread From: no-reply @ 2019-07-04 8:35 UTC (permalink / raw) To: kraxel; +Cc: peter.maydell, mst, qemu-devel, qemu-arm, qemu-ppc, kraxel, david Patchew URL: https://patchew.org/QEMU/20190703085416.21837-1-kraxel@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190703085416.21837-1-kraxel@redhat.com Subject: [Qemu-devel] [PULL 0/4] Vga 20190703 patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190704082736.25258-1-imammedo@redhat.com -> patchew/20190704082736.25258-1-imammedo@redhat.com Switched to a new branch 'test' === OUTPUT BEGIN === checkpatch.pl: no revisions returned for revlist '1' === OUTPUT END === Test command exited with code: 255 The full log is available at http://patchew.org/logs/20190703085416.21837-1-kraxel@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PULL 0/4] Vga 20190703 patches 2019-07-03 8:54 [Qemu-devel] [PULL 0/4] Vga 20190703 patches Gerd Hoffmann ` (6 preceding siblings ...) 2019-07-04 8:35 ` no-reply @ 2019-07-04 9:08 ` no-reply 7 siblings, 0 replies; 9+ messages in thread From: no-reply @ 2019-07-04 9:08 UTC (permalink / raw) To: kraxel; +Cc: peter.maydell, mst, qemu-devel, qemu-arm, qemu-ppc, kraxel, david Patchew URL: https://patchew.org/QEMU/20190703085416.21837-1-kraxel@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190703085416.21837-1-kraxel@redhat.com Subject: [Qemu-devel] [PULL 0/4] Vga 20190703 patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190704083647.30614-1-chen.zhang@intel.com -> patchew/20190704083647.30614-1-chen.zhang@intel.com * [new tag] patchew/20190704084115.24713-1-lvivier@redhat.com -> patchew/20190704084115.24713-1-lvivier@redhat.com Switched to a new branch 'test' === OUTPUT BEGIN === checkpatch.pl: no revisions returned for revlist '1' === OUTPUT END === Test command exited with code: 255 The full log is available at http://patchew.org/logs/20190703085416.21837-1-kraxel@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-07-04 9:09 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-07-03 8:54 [Qemu-devel] [PULL 0/4] Vga 20190703 patches Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 1/4] virtio-gpu: fix unmap in error path Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 2/4] virtio-gpu: check if the resource already exists in virtio_gpu_load() Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 3/4] hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct Gerd Hoffmann 2019-07-03 8:54 ` [Qemu-devel] [PULL 4/4] Add ati vgabios to INSTALL_BLOBS Gerd Hoffmann 2019-07-04 7:45 ` [Qemu-devel] [PULL 0/4] Vga 20190703 patches Peter Maydell 2019-07-04 8:05 ` no-reply 2019-07-04 8:35 ` no-reply 2019-07-04 9:08 ` no-reply
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).