From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A676C5B578 for ; Wed, 3 Jul 2019 07:51:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6148D2189E for ; Wed, 3 Jul 2019 07:51:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6148D2189E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hia31-0000t3-Nt for qemu-devel@archiver.kernel.org; Wed, 03 Jul 2019 03:51:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38449) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hia1x-0000Q5-Ue for qemu-devel@nongnu.org; Wed, 03 Jul 2019 03:50:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hia1v-0000wL-Tb for qemu-devel@nongnu.org; Wed, 03 Jul 2019 03:50:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50402) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hia1s-0000pI-8V for qemu-devel@nongnu.org; Wed, 03 Jul 2019 03:50:14 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FF2A308338F; Wed, 3 Jul 2019 07:49:57 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id BC1E55D9D3; Wed, 3 Jul 2019 07:49:54 +0000 (UTC) Date: Wed, 3 Jul 2019 09:49:50 +0200 From: Igor Mammedov To: Eduardo Habkost Message-ID: <20190703094950.56ea30cd@redhat.com> In-Reply-To: <20190702215726.23661-1-ehabkost@redhat.com> References: <20190702215726.23661-1-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 03 Jul 2019 07:50:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] numa: Make deprecation warnings conditional on !qtest_enabled() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 2 Jul 2019 18:57:26 -0300 Eduardo Habkost wrote: > This will help us avoid spurious warnings during "make check". > > Note that this will silence the warnings generated by > tests/numa-test, but not the ones generated by > tests/bios-tables-test. We still need to change > tests/bios-tables-test to use "-numa ...,memdev=" to silence > these warnings. > > Signed-off-by: Eduardo Habkost Reviewed-by: Eduardo Habkost > --- > numa.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/numa.c b/numa.c > index 1824c4e049..4988f25cd4 100644 > --- a/numa.c > +++ b/numa.c > @@ -35,6 +35,7 @@ > #include "qapi/qapi-visit-misc.h" > #include "hw/boards.h" > #include "sysemu/hostmem.h" > +#include "sysemu/qtest.h" > #include "hw/mem/pc-dimm.h" > #include "hw/mem/memory-device.h" > #include "qemu/option.h" > @@ -117,8 +118,10 @@ static void parse_numa_node(MachineState *ms, NumaNodeOptions *node, > > if (node->has_mem) { > numa_info[nodenr].node_mem = node->mem; > - warn_report("Parameter -numa node,mem is deprecated," > - " use -numa node,memdev instead"); > + if (!qtest_enabled()) { > + warn_report("Parameter -numa node,mem is deprecated," > + " use -numa node,memdev instead"); > + } > } > if (node->has_memdev) { > Object *o; > @@ -405,9 +408,11 @@ void numa_complete_configuration(MachineState *ms) > if (i == nb_numa_nodes) { > assert(mc->numa_auto_assign_ram); > mc->numa_auto_assign_ram(mc, numa_info, nb_numa_nodes, ram_size); > - warn_report("Default splitting of RAM between nodes is deprecated," > - " Use '-numa node,memdev' to explictly define RAM" > - " allocation per node"); > + if (!qtest_enabled()) { > + warn_report("Default splitting of RAM between nodes is deprecated," > + " Use '-numa node,memdev' to explictly define RAM" > + " allocation per node"); > + } > } > > numa_total = 0;