From: Cornelia Huck <cohuck@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: eric.auger@redhat.com, farman@linux.ibm.com, alifm@linux.ibm.com,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vfio-ccw: Test vfio_set_irq_signaling() return value
Date: Wed, 3 Jul 2019 10:41:55 +0200 [thread overview]
Message-ID: <20190703104155.5ccdacf8.cohuck@redhat.com> (raw)
In-Reply-To: <156209642116.14915.9598593247782519613.stgit@gimli.home>
On Tue, 02 Jul 2019 13:41:34 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:
> Coverity doesn't like that most callers of vfio_set_irq_signaling() check
> the return value and doesn't understand the equivalence of testing the
> error pointer instead. Test the return value consistently.
>
> Reported-by: Coverity (CID 1402783)
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> hw/vfio/ccw.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Thanks, queued to s390-fixes.
next prev parent reply other threads:[~2019-07-03 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 19:41 [Qemu-devel] [PATCH] vfio-ccw: Test vfio_set_irq_signaling() return value Alex Williamson
2019-07-03 1:09 ` no-reply
2019-07-03 8:30 ` Auger Eric
2019-07-03 8:41 ` Cornelia Huck [this message]
2019-07-03 8:51 ` Philippe Mathieu-Daudé
2019-07-03 10:49 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703104155.5ccdacf8.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=eric.auger@redhat.com \
--cc=farman@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).