From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0927C0650E for ; Wed, 3 Jul 2019 09:17:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA65E2189E for ; Wed, 3 Jul 2019 09:17:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA65E2189E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hibOm-0001WB-V5 for qemu-devel@archiver.kernel.org; Wed, 03 Jul 2019 05:17:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51690) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiaq8-0006Qu-Rv for qemu-devel@nongnu.org; Wed, 03 Jul 2019 04:42:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiaq6-0008Fm-9D for qemu-devel@nongnu.org; Wed, 03 Jul 2019 04:42:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46532) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hiaq5-00086Q-OA; Wed, 03 Jul 2019 04:42:06 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5A562308339E; Wed, 3 Jul 2019 08:42:03 +0000 (UTC) Received: from gondolin (dhcp-192-192.str.redhat.com [10.33.192.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98EB358CB7; Wed, 3 Jul 2019 08:41:57 +0000 (UTC) Date: Wed, 3 Jul 2019 10:41:55 +0200 From: Cornelia Huck To: Alex Williamson Message-ID: <20190703104155.5ccdacf8.cohuck@redhat.com> In-Reply-To: <156209642116.14915.9598593247782519613.stgit@gimli.home> References: <156209642116.14915.9598593247782519613.stgit@gimli.home> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 03 Jul 2019 08:42:03 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] vfio-ccw: Test vfio_set_irq_signaling() return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eric.auger@redhat.com, farman@linux.ibm.com, alifm@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 02 Jul 2019 13:41:34 -0600 Alex Williamson wrote: > Coverity doesn't like that most callers of vfio_set_irq_signaling() check > the return value and doesn't understand the equivalence of testing the > error pointer instead. Test the return value consistently. > > Reported-by: Coverity (CID 1402783) > Signed-off-by: Alex Williamson > --- > hw/vfio/ccw.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Thanks, queued to s390-fixes.