From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC0EC0650E for ; Wed, 3 Jul 2019 12:16:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 776FF218A0 for ; Wed, 3 Jul 2019 12:16:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 776FF218A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hieBK-0001W2-E1 for qemu-devel@archiver.kernel.org; Wed, 03 Jul 2019 08:16:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49972) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hie9f-0000oT-5F for qemu-devel@nongnu.org; Wed, 03 Jul 2019 08:14:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hie9e-0005Iu-2j for qemu-devel@nongnu.org; Wed, 03 Jul 2019 08:14:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46278) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hie9d-00055n-SM for qemu-devel@nongnu.org; Wed, 03 Jul 2019 08:14:30 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0DBAD7EBBD for ; Wed, 3 Jul 2019 12:13:53 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 04FAD1001DCF; Wed, 3 Jul 2019 12:13:43 +0000 (UTC) Date: Wed, 3 Jul 2019 14:13:39 +0200 From: Igor Mammedov To: Eduardo Habkost Message-ID: <20190703141339.7dad82ab@redhat.com> In-Reply-To: <20190702220310.GT5198@habkost.net> References: <20190702140745.27767-1-imammedo@redhat.com> <20190702140745.27767-3-imammedo@redhat.com> <20190702171901.GQ5198@habkost.net> <20190702220310.GT5198@habkost.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 03 Jul 2019 12:14:01 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 2/2] tests: use -numa memdev option in tests instead of legacy 'mem' option X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , Thomas Huth , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 2 Jul 2019 19:03:10 -0300 Eduardo Habkost wrote: > On Tue, Jul 02, 2019 at 02:19:01PM -0300, Eduardo Habkost wrote: > > On Tue, Jul 02, 2019 at 10:07:45AM -0400, Igor Mammedov wrote: > > > it will test preferred memdev option more extensively and remove > > > undesired deprecation warnings during 'make check' > > > > > > Signed-off-by: Igor Mammedov > > > --- > > [...] > > > diff --git a/tests/numa-test.c b/tests/numa-test.c > > > index 8de8581231..902e8de4d1 100644 > > > --- a/tests/numa-test.c > > > +++ b/tests/numa-test.c > > > @@ -26,8 +26,10 @@ static void test_mon_explicit(const void *data) > > > QTestState *qts; > > > > > > cli = make_cli(data, "-smp 8 " > > > - "-numa node,nodeid=0,cpus=0-3 " > > > - "-numa node,nodeid=1,cpus=4-7 "); > > > + "-object memory-backend-ram,id=ram0,size=64M " > > > + "-object memory-backend-ram,id=ram1,size=64M " > > > + "-numa node,nodeid=0,cpus=0-3,memdev=ram0 " > > > + "-numa node,nodeid=1,cpus=4-7,memdev=ram1 "); > > > > These changes break on ppc64, where default RAM size is 512 MiB > > and it has to be a multiple of 256 MiB. > > > > Can't we just make the warnings be conditional on > > !qtest_enabled(), like we already do elsewhere? > > The answer is: we can, but this is not enough for > bios-tables-test.c because it doesn't use accel=qtest. I've > removed the numa-test.c changes from this patch, and added the > fix I have submitted at: > > Subject: numa: Make deprecation warnings conditional on !qtest_enabled() > Message-Id: <20190702215726.23661-1-ehabkost@redhat.com> acked as it fixes immediate issue with warnings. I'll work on numa-test.c some more, since simple replacing of mem with memdev is not enough