qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Richard Henderson <rth@twiddle.net>
Cc: Like Xu <like.xu@linux.intel.com>
Subject: [Qemu-devel] [PULL v4 01/43] hw/boards: Add struct CpuTopology to MachineState
Date: Wed,  3 Jul 2019 15:06:44 -0300	[thread overview]
Message-ID: <20190703180726.31267-2-ehabkost@redhat.com> (raw)
In-Reply-To: <20190703180726.31267-1-ehabkost@redhat.com>

From: Like Xu <like.xu@linux.intel.com>

The cpu topology property CpuTopology is added to the MachineState
and its members are initialized with the leagcy global smp variables.

From this commit, the code in the system emulation mode is supposed to
use cpu topology variables from MachineState instead of the global ones
defined in vl.c and there is no semantic change.

Suggested-by: Igor Mammedov <imammedo@redhat.com>
Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190518205428.90532-2-like.xu@linux.intel.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 include/hw/boards.h | 15 +++++++++++++++
 vl.c                |  5 +++++
 2 files changed, 20 insertions(+)

diff --git a/include/hw/boards.h b/include/hw/boards.h
index eaa050a7ab..31dab77b4b 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -231,6 +231,20 @@ typedef struct DeviceMemoryState {
     MemoryRegion mr;
 } DeviceMemoryState;
 
+/**
+ * CpuTopology:
+ * @cpus: the number of present logical processors on the machine
+ * @cores: the number of cores in one package
+ * @threads: the number of threads in one core
+ * @max_cpus: the maximum number of logical processors on the machine
+ */
+typedef struct CpuTopology {
+    unsigned int cpus;
+    unsigned int cores;
+    unsigned int threads;
+    unsigned int max_cpus;
+} CpuTopology;
+
 /**
  * MachineState:
  */
@@ -273,6 +287,7 @@ struct MachineState {
     const char *cpu_type;
     AccelState *accelerator;
     CPUArchIdList *possible_cpus;
+    CpuTopology smp;
     struct NVDIMMState *nvdimms_state;
 };
 
diff --git a/vl.c b/vl.c
index 99a56b5556..e9698cb1b1 100644
--- a/vl.c
+++ b/vl.c
@@ -4059,6 +4059,11 @@ int main(int argc, char **argv, char **envp)
 
     smp_parse(qemu_opts_find(qemu_find_opts("smp-opts"), NULL));
 
+    current_machine->smp.cpus = smp_cpus;
+    current_machine->smp.max_cpus = max_cpus;
+    current_machine->smp.cores = smp_cores;
+    current_machine->smp.threads = smp_threads;
+
     /* sanity-check smp_cpus and max_cpus against machine_class */
     if (smp_cpus < machine_class->min_cpus) {
         error_report("Invalid SMP CPUs %d. The min CPUs "
-- 
2.18.0.rc1.1.g3f1ff2140



  reply	other threads:[~2019-07-03 18:09 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-03 18:06 [Qemu-devel] [PULL v4 00/43] Machine and x86 queue, 2019-07-03 Eduardo Habkost
2019-07-03 18:06 ` Eduardo Habkost [this message]
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 02/43] machine: Refactor smp-related call chains to pass MachineState Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 03/43] general: Replace global smp variables with smp machine properties Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 04/43] hw/ppc: Replace global smp variables with machine smp properties Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 05/43] hw/riscv: " Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 06/43] hw/s390x: " Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 07/43] hw/i386: " Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 08/43] hw/arm: " Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 09/43] hw: Replace global smp variables with MachineState for all remaining archs Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 10/43] vl.c: Replace smp global variables with smp machine properties Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 11/43] i386: Add die-level cpu topology to x86CPU on PCMachine Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 12/43] hw/i386: Adjust nr_dies with configured smp_dies for PCMachine Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 13/43] i386/cpu: Consolidate die-id validity in smp context Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 14/43] i386: Update new x86_apicid parsing rules with die_offset support Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 15/43] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size() Eduardo Habkost
2019-07-03 18:06 ` [Qemu-devel] [PULL v4 16/43] machine: show if CLI option '-numa node, mem' is supported in QAPI schema Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 17/43] numa: deprecate 'mem' parameter of '-numa node' option Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 18/43] numa: deprecate implict memory distribution between nodes Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 19/43] hppa: Delete unused hppa_cpu_list() function Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 20/43] target/i386: fix feature check in hyperv-stub.c Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 21/43] deprecate -mem-path fallback to anonymous RAM Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 22/43] i386: Don't print warning if phys-bits was set automatically Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 23/43] i386: Fix signedness of hyperv_spinlock_attempts Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 24/43] i386: make 'hv-spinlocks' a regular uint32 property Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 25/43] x86/cpu: use FeatureWordArray to define filtered_features Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 26/43] i386: Remove unused host_cpudef variable Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 27/43] target/i386: Add CPUID.1F generation support for multi-dies PCMachine Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 28/43] machine: Refactor smp_parse() in vl.c as MachineClass::smp_parse() Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 29/43] vl.c: Add -smp, dies=* command line support and update doc Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 30/43] qmp: Add deprecation information to query-machines Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 31/43] i386: Introduce SnowRidge CPU model Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 32/43] qmp: Add "alias-of" field to query-cpu-definitions Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 33/43] i386: Add x-force-features option for testing Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 34/43] i386: Get model-id from CPU object on "-cpu help" Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 35/43] i386: Register versioned CPU models Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 36/43] i386: Define -IBRS, -noTSX, -IBRS versions of " Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 37/43] i386: Replace -noTSX, -IBRS, -IBPB CPU models with aliases Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 38/43] i386: Make unversioned CPU models be aliases Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 39/43] docs: Deprecate CPU model runnability guarantees Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 40/43] i386: Add Cascadelake-Server-v2 CPU model Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 41/43] numa: Make deprecation warnings conditional on !qtest_enabled() Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 42/43] numa: allow memory-less nodes when using memdev as backend Eduardo Habkost
2019-07-03 18:07 ` [Qemu-devel] [PULL v4 43/43] tests: use -numa memdev option in tests instead of legacy 'mem' option Eduardo Habkost
2019-07-03 18:49 ` [Qemu-devel] [PULL v4 00/43] Machine and x86 queue, 2019-07-03 Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190703180726.31267-2-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=like.xu@linux.intel.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).