From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F24C5B578 for ; Sat, 6 Jul 2019 04:12:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3F2A216B7 for ; Sat, 6 Jul 2019 04:12:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W0SKeNVq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3F2A216B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjc4G-0008SQ-7R for qemu-devel@archiver.kernel.org; Sat, 06 Jul 2019 00:12:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53252) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjc1K-0006ES-CN for qemu-devel@nongnu.org; Sat, 06 Jul 2019 00:09:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjc1I-0000kf-Ec for qemu-devel@nongnu.org; Sat, 06 Jul 2019 00:09:54 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:42977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjc1G-0000ii-Iv for qemu-devel@nongnu.org; Sat, 06 Jul 2019 00:09:51 -0400 Received: by mail-pg1-x541.google.com with SMTP id t132so5061031pgb.9 for ; Fri, 05 Jul 2019 21:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YfW1aH+Wpw10vSj+L0zxMi7E9GI7IXk5GtJx8ieye+k=; b=W0SKeNVqym5z1mgVyAkLzSoTBlePkQ5LGRkGPvvn05zGU8qIX2hTd7bm+ZX6vYQL11 rfvO9Ql1UybmuOs6S8GhjG0u24iP9gRpst7UBwT2UyT35yP+CncSs3EgjM1ULUkCDr7v +0g1aPxBvco3S6K0Aud5TwVGg3QHZf6QAIrkVGDHBVPMLEY2NgtY/RD6W3XZXIiAVSpm a+lV6JiqKuwNHS7HUiuEshThuBu/sb+PB4Bf9cumIM5fcnAep6Yd75Y7JHcIz5qYRhlZ Xg85YYu2pEtBwVCWVp4aynFIRIaAljgC9cdnXXKoejMZWk8x1CzAJ2X3TFH/aUTTIoWu 3RdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YfW1aH+Wpw10vSj+L0zxMi7E9GI7IXk5GtJx8ieye+k=; b=DRDJYrwRsp3czxD3oN5m1tHJhHMknwCdTT9P+qX2DswtUiRShAR5A/wRBdSKr96NrH EQ4W53/Yoj9O05B9P54Xxa4j+WKJhTqhyc4Rw4aUHddy59l8qxd+GJ2iPk7i2mMrsqAB 4xVVscCSYGXbRE/+hhw1KiSxNrrBLhsqourg48RXXBEGKWslqWSyRYFkBsADiuHDTAG2 OXpFx+8jUNVo/qPgoQda6G334A3N4p3QplKBn+xwpzbKXKx0US7fvT7pumE/WgyRu4hA V1FzjG0IjOAN88eT+g6KJldE5Is3XO/CFx7hfyo4Lb82rSQHI8UrFO9wBqvwjqNUBUCj Bpbg== X-Gm-Message-State: APjAAAVfIvI9Zpc3IZzdWqVwMzhRtpQIVuJFa3O/AXhxRHWfV178pSwp xgVSnhlqXRaAPOuVdpFtyQfydPdC X-Google-Smtp-Source: APXvYqzPAq0vMI05Jg7SnrRYwfS1j/RbNAd8wPHQFmTynqTZZO1pCZjhnCxFi/eTKQrpox3XdzHGZA== X-Received: by 2002:a63:c20e:: with SMTP id b14mr8805376pgd.96.1562386188503; Fri, 05 Jul 2019 21:09:48 -0700 (PDT) Received: from localhost.localdomain ([2405:204:22f:6255:6f39:949d:5942:eaaf]) by smtp.gmail.com with ESMTPSA id q126sm17330847pfq.123.2019.07.05.21.09.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Jul 2019 21:09:47 -0700 (PDT) From: Sukrit Bhatnagar To: qemu-devel@nongnu.org Date: Sat, 6 Jul 2019 09:39:39 +0530 Message-Id: <20190706040940.7884-2-skrtbhtngr@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190706040940.7884-1-skrtbhtngr@gmail.com> References: <20190706040940.7884-1-skrtbhtngr@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [RFC v2 1/2] hw/pvrdma: make DSR mapping idempotent in load_dsr() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yuval Shaia Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Map to DSR only when there is no mapping done already i.e., when dev->dsr_info.dsr is NULL. This allows the rest of mappings and ring inits to be done by calling load_dsr() when DSR has already been mapped to, somewhere else. Move free_dsr() out of load_dsr() and call it before the latter as and when needed. This aids the case where load_dsr() is called having DSR mapping already done, but the rest of map and init operations are pending, and prevents an unmap of the DSR. Cc: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatnagar --- hw/rdma/vmw/pvrdma_main.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index adcf79cd63..6c90db96f9 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -172,15 +172,15 @@ static int load_dsr(PVRDMADev *dev) DSRInfo *dsr_info; struct pvrdma_device_shared_region *dsr; - free_dsr(dev); - - /* Map to DSR */ - dev->dsr_info.dsr = rdma_pci_dma_map(pci_dev, dev->dsr_info.dma, - sizeof(struct pvrdma_device_shared_region)); if (!dev->dsr_info.dsr) { - rdma_error_report("Failed to map to DSR"); - rc = -ENOMEM; - goto out; + /* Map to DSR */ + dev->dsr_info.dsr = rdma_pci_dma_map(pci_dev, dev->dsr_info.dma, + sizeof(struct pvrdma_device_shared_region)); + if (!dev->dsr_info.dsr) { + rdma_error_report("Failed to map to DSR"); + rc = -ENOMEM; + goto out; + } } /* Shortcuts */ @@ -402,6 +402,7 @@ static void pvrdma_regs_write(void *opaque, hwaddr addr, uint64_t val, case PVRDMA_REG_DSRHIGH: trace_pvrdma_regs_write(addr, val, "DSRHIGH", ""); dev->dsr_info.dma |= val << 32; + free_dsr(dev); load_dsr(dev); init_dsr_dev_caps(dev); break; -- 2.21.0