From: Thomas Huth <huth@tuxfamily.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/4] m68k: Add basic support for the NeXTcube machine
Date: Sat, 6 Jul 2019 22:19:09 +0200 [thread overview]
Message-ID: <20190706221909.3f1b3d53@thl530.multi.box> (raw)
In-Reply-To: <156242845202.4200.11224412072242119697@c4a48874b076>
Am Sat, 6 Jul 2019 08:54:13 -0700 (PDT)
schrieb no-reply@patchew.org:
> Patchew URL:
> https://patchew.org/QEMU/20190706154308.7280-1-huth@tuxfamily.org/
>
> Hi,
>
> This series seems to have some coding style problems. See output
> below for more information:
[...]
> ERROR: space required after that ',' (ctx:VxV)
> #938: FILE: hw/m68k/next-cube.c:903:
> + memory_region_init_alias(aliasmem, NULL,"next.unknown", mmiomem,
> 0xc0020, ^
Stupid typo - I'll fix of course, and change the name of the region to
"next.alias" or something similar.
Thomas
prev parent reply other threads:[~2019-07-06 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 15:43 [Qemu-devel] [PATCH v3 0/4] m68k: Add basic support for the NeXTcube machine Thomas Huth
2019-07-06 15:43 ` [Qemu-devel] [PATCH v3 1/4] m68k: Add NeXTcube framebuffer device emulation Thomas Huth
2019-07-06 15:43 ` [Qemu-devel] [PATCH v3 2/4] m68k: Add NeXTcube keyboard device Thomas Huth
2019-07-06 15:43 ` [Qemu-devel] [PATCH v3 3/4] m68k: Add NeXTcube machine Thomas Huth
2019-07-06 15:43 ` [Qemu-devel] [PATCH v3 4/4] m68k: Add an entry for the NeXTcube machine to the MAINTAINERS file Thomas Huth
2019-07-06 15:54 ` [Qemu-devel] [PATCH v3 0/4] m68k: Add basic support for the NeXTcube machine no-reply
2019-07-06 20:19 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190706221909.3f1b3d53@thl530.multi.box \
--to=huth@tuxfamily.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).