From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Sukrit Bhatnagar <skrtbhtngr@gmail.com>,
Michal Privoznik <mprivozn@redhat.com>,
qemu-devel@nongnu.org, Yuval Shaia <yuval.shaia@oracle.com>
Subject: Re: [Qemu-devel] [RFC v2 0/2] Add live migration support in the PVRDMA device
Date: Mon, 8 Jul 2019 10:38:33 +0100 [thread overview]
Message-ID: <20190708093833.GC3082@redhat.com> (raw)
In-Reply-To: <26ae890e-ca8a-6a5b-0d93-67cd266c8e93@gmail.com>
On Sat, Jul 06, 2019 at 10:04:55PM +0300, Marcel Apfelbaum wrote:
> Hi Sukrit,
>
> On 7/6/19 7:09 AM, Sukrit Bhatnagar wrote:
> > Changes in v2:
> >
> > * Modify load_dsr() such that dsr mapping is not performed if dsr value
> > is non-NULL. Also move free_dsr() out of load_dsr() and call it right
> > before if needed. These two changes will allow us to call load_dsr()
> > even when we have already done dsr mapping and would like to go on
> > with the rest of mappings.
> >
> > * Use VMStateDescription instead of SaveVMHandlers to describe migration
> > state. Also add fields for parent PCI object and MSIX.
> >
> > * Use a temporary structure (struct PVRDMAMigTmp) to hold some fields
> > during migration. These fields, such as cmd_slot_dma and resp_slot_dma
> > inside dsr, do not fit into VMSTATE macros as their container
> > (dsr_info->dsr) will not be ready until it is mapped on the dest.
> >
> > * Perform mappings to CQ and event notification rings after the state is
> > loaded. This is an extension to the mappings performed in v1;
> > following the flow of load_dsr(). All the mappings are succesfully
> > done on the dest on state load.
>
> Nice!
>
> > Link(s) to v1:
> > https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04924.html
> > https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04923.html
> >
> >
> > Things working now (were not working at the time of v1):
> >
> > * vmxnet3 is migrating successfully. The issue was in the migration of
> > its PCI configuration space, and is solved by the patch Marcel had sent:
> > https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01500.html
> >
> > * There is no problem due to BounceBuffers which were failing the dma mapping
> > calls in state load logic earlier. Not sure exactly how it went away. I am
> > guessing that adding the PCI and MSIX state to migration solved the issue.
> >
>
> I am sure it was connected somehow, anyway, I am glad we can continue
> with the project.
>
> > What is still needed:
> >
> > * A workaround to get libvirt to support same-host migration. Since
> > the problems faced in v1 (mentioned above) are out of the way, we
> > can move further, and in doing so, we will need this.
>
> [Adding Daniel and Michal]
> Is there anyway to test live-migration for libvirt domains on the same host?
> Even a 'hack' would be enough.
Create two VMs on your host & run inside those. Or create two containers
if you want a lighter weight solution. You must have two completely
independant libvirtd instances, sharing nothing, except optionally where
you store disk images.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-07-08 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 4:09 [Qemu-devel] [RFC v2 0/2] Add live migration support in the PVRDMA device Sukrit Bhatnagar
2019-07-06 4:09 ` [Qemu-devel] [RFC v2 1/2] hw/pvrdma: make DSR mapping idempotent in load_dsr() Sukrit Bhatnagar
2019-07-06 4:09 ` [Qemu-devel] [RFC v2 2/2] hw/pvrdma: add live migration support Sukrit Bhatnagar
2019-07-08 5:13 ` Yuval Shaia
2019-07-10 20:14 ` Sukrit Bhatnagar
2019-07-06 19:04 ` [Qemu-devel] [RFC v2 0/2] Add live migration support in the PVRDMA device Marcel Apfelbaum
2019-07-08 9:38 ` Daniel P. Berrangé [this message]
2019-07-08 18:58 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708093833.GC3082@redhat.com \
--to=berrange@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=skrtbhtngr@gmail.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).